Goober5000andClaude Fable 5 009529b235 guard against empty weapon banks in external model render paths ...

ship_render_weapon_models(), HudGaugeHardpoints::render(), and
ship_stop_fire_primary_bank() indexed Weapon_info[] with the bank's
weapon index without checking for an empty bank (-1).  Banks within
num_*_banks are normally populated, but other code that iterates banks
treats them as possibly empty and guards accordingly (e.g.
ship_do_cargo_hidden, ship_page_in), so these paths now do too.  In
the hardpoints gauge an empty primary bank still draws its firing
point circles.

Co-Authored-By: Claude Fable 5 <[email protected]>

2026-07-13 13:19:23 -04:00

..

actions

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

ai

consolidate external weapon model firing point selection; fix two bugs

2026-07-13 13:19:23 -04:00

anim

add documentation for issue 4148

2026-04-30 00:35:19 -04:00

asteroid

more robust handling of modelinstance teardown

2026-06-12 22:39:50 -04:00

autopilot

change Player_use_ai from int to bool

2025-04-06 02:11:52 -04:00

bmpman

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

camera

Off is 1286

2026-07-11 21:02:36 -04:00

cfile

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

cfilearchiver

Changes the usage printout as per discussion

2017-02-16 10:24:51 +01:00

cfileextractor

Fixes Configuration error for the CFileArchiver/Extractor projects

2017-02-15 16:12:59 +01:00

cheats_table

use std::move() for local variables that are copied but not reused (#7308)

2026-05-07 14:40:38 +09:00

cmdline

TTS Speech rework (#7357)

2026-05-14 08:07:11 -04:00

cmeasure

Add feature to customize how CMs are launched (#7224)

2026-03-05 15:15:56 -05:00

controlconfig

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

cutscene

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

ddsutils

Merge pull request #7472 from MjnMixael/qtfred-fix-image-picker-dds

2026-07-05 18:45:28 +02:00

debris

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

debugconsole

use std::move() for local variables that are copied but not reused (#7308)

2026-05-07 14:40:38 +09:00

decals

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

def_files

fix compile error in shadow shader (#7592)

2026-07-11 02:46:18 +02:00

events

Add discord Rich Presence support

2018-07-15 19:37:24 +02:00

exceptionhandler

improve campaign file extension handling (#6443)

2024-12-22 22:31:58 +01:00

executor

Add scripting API for custom execution context

2020-08-11 09:38:39 +02:00

external_dll

Add improved head tracking code

2016-08-13 21:43:23 +02:00

fireball

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

gamehelp

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

gamesequence

Retail ingame options (#5895)

2024-02-27 13:09:34 -05:00

gamesnd

Fix CTD when an interface sound is shared with a gameplay sound (#7488)

2026-05-30 23:45:22 +02:00

globalincs

clean up and extend the linked list iterator adapter

2026-07-11 20:28:45 -04:00

graphics

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

headtracking

add _WIN32 guard to trackir/freetrack

2025-08-18 11:56:26 -04:00

hud

guard against empty weapon banks in external model render paths

2026-07-13 13:19:23 -04:00

iff_defs

Suppress Coverity GLOBAL_INIT_ORDER false positives for safe globals

2026-03-22 15:00:25 -04:00

inetfile

fix various compiler warnings

2025-08-18 11:59:22 -04:00

io

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

jpgutils

remove support for memory mapped files (#6748)

2025-06-05 17:53:13 -04:00

jumpnode

Merge pull request #7520 from Goober5000/fix/std_exchange

2026-07-06 03:11:12 -04:00

ktxutils

KTX1 / ETC2 Compressed textures support (#7070)

2026-05-26 12:21:43 +02:00

lab

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

libs

unlimited mission titles

2026-05-12 11:31:20 -04:00

lighting

Suppress Coverity GLOBAL_INIT_ORDER false positives for safe globals

2026-03-22 15:00:25 -04:00

localization

TTS Speech rework (#7357)

2026-05-14 08:07:11 -04:00

math

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

menuui

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

mission

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

missioneditor

Merge pull request #7600 from Goober5000/fix/ship_demotion

2026-07-12 20:15:54 -04:00

missionui

Merge pull request #7557 from Goober5000/fix/brief_stage_move

2026-07-08 00:14:46 -04:00

mod_table

Shadow Overhaul (#7529)

2026-07-04 16:08:41 +02:00

model

revive $Weapon Model Draw Distance; fix attached weapon model LOD depth

2026-07-13 13:19:23 -04:00

nebula

Fullneb Revamp (#7352)

2026-05-28 14:43:48 +09:00

network

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

object

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

observer

rename ship_get_eye to object_get_eye and consolidate object/ship cases where appropriate

2025-02-22 19:29:11 -05:00

options

TTS Speech rework (#7357)

2026-05-14 08:07:11 -04:00

osapi

Add OpenGL ES Compatibility Layer (#7137)

2026-05-25 01:30:42 +02:00

parse

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

particle

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

pcxutils

add documentation for issue 4148

2026-04-30 00:35:19 -04:00

physics

fix some abs() type conversion warnings

2025-08-18 11:56:39 -04:00

pilotfile

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

playerman

unlimited mission titles

2026-05-12 11:31:20 -04:00

pngutils

remove support for memory mapped files (#6748)

2025-06-05 17:53:13 -04:00

popup

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

prop

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

radar

Mines weapon type & weapon proximity triggers (#7461)

2026-06-05 14:06:00 +09:00

render

"change atan2_safe to atan2" followup (#7531)

2026-06-18 10:34:16 +09:00

scpui

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

scripting

Merge pull request #7583 from Goober5000/fix/lua_secondary_bank_fields

2026-07-10 23:53:17 -04:00

ship

guard against empty weapon banks in external model render paths

2026-07-13 13:19:23 -04:00

sound

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

species_defs

use std::move() for local variables that are copied but not reused (#7308)

2026-05-07 14:40:38 +09:00

starfield

use std::move() for local variables that are copied but not reused (#7308)

2026-05-07 14:40:38 +09:00

stats

use std::move() for local variables that are copied but not reused (#7308)

2026-05-07 14:40:38 +09:00

tgautils

remove support for memory mapped files (#6748)

2025-06-05 17:53:13 -04:00

tracing

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

ui

fix custom mouse cursors (#6953)

2025-08-18 21:48:51 -04:00

utils

avoid undefined behavior from UNREACHABLE on reachable code paths (#7555)

2026-07-09 11:20:25 +09:00

weapon

consolidate duplicated per-weapon page-in code

2026-07-13 13:19:22 -04:00

windows_stub

fix various compiler warnings

2025-08-18 11:59:22 -04:00

CMakeLists.txt

update libpcp to lastest main (#6963)

2025-08-22 07:18:48 -04:00

prefix_header.h

Add pstypes.h to precompiled header

2020-08-29 11:26:16 +02:00

shaders.cmake

Add first basic rendering with Vulkan

2020-10-14 22:21:45 +02:00

source_groups.cmake

fix four more shallow-ownership hazards in by-value types

2026-07-06 13:33:49 -04:00

voice_rec.cmake

Move build system to CMake

2016-07-22 12:07:19 +02:00