Goober5000andClaude Fable 5 60c554354c fix dual fire handling for banks that cannot use it ...

The Secondary_dual_fire flag is per-ship, but not every secondary bank
can dual fire.  Previously the HUD drew the dual fire link icon even
when the armed bank had only one firepoint, and firing such a bank
cleared the flag entirely, silently discarding the player's dual fire
preference for the other banks.

Extend the ignored-rather-than-cleared approach already established
for no-doublefire weapons to the single-firepoint case:

- add ship_secondary_bank_can_dual_fire() as the single source of truth
  for bank validity, No_doublefire, ai_profiles restrictions, and
  firepoint count
- ship_fire_secondary() now fires single and leaves the flag alone when
  the bank cannot dual fire, instead of removing the flag
- the weapons gauges and the hardpoints gauge consult the helper, so the
  link icon and second-firepoint highlight are no longer drawn for
  incapable banks
- the dual fire toggle on a single-firepoint bank now explains why it
  cannot dual fire and leaves the preference untouched
- restoring the saved dual fire preference no longer depends on bank 0's
  firepoint count, since incapable banks now simply ignore the flag
- key control and force feedback also consult the helper

Co-Authored-By: Claude Fable 5 <[email protected]>

2026-07-28 01:08:07 -04:00

..

managepilot.cpp

unlimited mission titles

2026-05-12 11:31:20 -04:00

managepilot.h

Improve Pilot version checks (#3988)

2022-02-13 16:07:01 -06:00

player.h

add scripted flight cursor sensitivity (#7149)

2026-02-25 08:30:42 -05:00

playercontrol.cpp

fix dual fire handling for banks that cannot use it

2026-07-28 01:08:07 -04:00