mirror of
https://github.com/scp-fs2open/fs2open.github.com.git
synced 2026-11-12 19:06:09 -10:00
Goober5000
5f8234d1cd
Several related fixes: 1. Copy the actual ship name, not the display name, to `killer_parent_name` for two reasons: 1a. Since `killer_parent_name` is used to look up the ship, it must be the actual ship name, not the display name. 1b. Copying the display name can cause a buffer overflow because display names can be longer than 31 characters. 2. The display name functionality is moved to the more appropriate location in `player_generate_death_message()`. 3. Remove `player_get_killer_weapon_name()` which only served as a proxy check for whether the weapon index was used or not. 4. Use `ship_registry_get()` rather than `ship_name_lookup()`. 5. Add comments to clarify the use of `killer_parent_name`.