mirror of
https://github.com/scp-fs2open/fs2open.github.com.git
synced 2026-11-10 04:31:34 -10:00
Allen A. Babb
cf83573b2a
* rename pilotfile::version to pilotfile::plr_ver * Fix typo in warning message * set plr_ver and csg_ver to PLR_VERSION_INVALID on init and close * add PLAYER_FLAGS_PLR_VER_LOWER and *_CONTROLS flags to player defines * Add popup to intercept the player before going into the mainhall with an old pilot * Move the Constrols5 info popup into the mainhall * Modifiy pilotfile::verify() to allow player flags to be passed on to callers * Rename valid_pilot_lang() to valid_pilot() * valid_pilot() checks plr_version of the pilot and prompts the user if they want to continue loading or not * add no_popup param to valid_pilot() to allow scripting to use it * Correctly clear the PLR_VER_CONTROLS player flag * operator== is not operator+= * don't clear player flags when closing a pilot file * player tips popup comes after any warnings * save committed pilot on playermenu close * doxy playermenu::player_creat_new_pilot() and magagepilot::init_new_pilot() * * add validation/safety catch in the barracks to prompt user if they want to select/convert a pilot with version mismatch * PLAYER_FLAGS_PLR_VER_CONTROLS is a savable flag, cleared in the mainhall after the popup is dismiessed * Move version flag sets in plr::load_player() and plr::verify() after calls to player_read_flags() * Drop hints to players they should use a clone of the pilot in version prompt. * Went ahead and added a VERSION_HIGHER flag and conditional in valid_pilot() * Move Controsl5 notice popup into playermenu, next to the player_tips_pop(). Also allows player to "Don't show this again" * Ignore plr version flags during unit tests since .plr -> .json conversion is never a pure clone * Address CI issues: * clang-tidy: use nullptr (modernize-use-nullptr) * Add XSTR support to valid_pilot() and player_tips_constrols() popups. * * Rename new PLAYER_FLAGS to something more descriptive * Edit Popup text to be a bit more concise * Add missing punctuation to language popup