shadps4-emu/ext-SDL
1
0
Fork 0
mirror of https://github.com/shadps4-emu/ext-SDL.git synced 2025-02-12 22:39:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix std::thread memory leak

Browse Source 
In the stdcpp thread implementation, the allocated std::thread objects were never deleted after joining/detaching
This commit is contained in:
Edoardo Lolletti 2024-06-24 19:45:37 +02:00 committed by Ryan C. Gordon
parent 138eb8649d
commit 20dbe90771
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/thread/stdcpp/SDL_systhread.cpp
View File

@ -121,8 +121,12 @@ SDL_SYS_WaitThread(SDL_Thread *thread)
try {
std::thread *cpp_thread = (std::thread *)thread->handle;
if (cpp_thread->joinable()) {
cpp_thread->join();
if (cpp_thread) {
if (cpp_thread->joinable()) {
cpp_thread->join();
}
delete cpp_thread;
thread->handle = nullptr;
}
} catch (std::system_error &) {
// An error occurred when joining the thread. SDL_WaitThread does not,
@ -140,8 +144,12 @@ SDL_SYS_DetachThread(SDL_Thread *thread)
try {
std::thread *cpp_thread = (std::thread *)thread->handle;
if (cpp_thread->joinable()) {
cpp_thread->detach();
if (cpp_thread) {
if (cpp_thread->joinable()) {
cpp_thread->detach();
}
delete cpp_thread;
thread->handle = nullptr;
}
} catch (std::system_error &) {
// An error occurred when detaching the thread. SDL_DetachThread does not,