shadps4-emu/ext-cryptopp
1
0
Fork 0
mirror of https://github.com/shadps4-emu/ext-cryptopp.git synced 2024-11-23 09:59:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Clear Coverity finding CONSTANT_EXPRESSION_RESULT (CID 182772)

Browse Source 
This may create a MSC warning about a conditional expression being constant
This commit is contained in:
Jeffrey Walton 2017-08-18 07:59:21 -04:00
parent b61953a7a7
commit 42b7c4ea56
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
secblock.h
View File

@ -99,11 +99,15 @@ protected:
//! because the latter is not a constexpr. Some compilers, like Clang, do not
//! optimize it well under all circumstances. Compilers like GCC, ICC and MSVC appear
//! to optimize it well in either form.
//! \details The <tt>sizeof(T) != 1</tt> in the condition attempts to help the
//! compiler optimize the check for byte types. Coverity findings for
//! CONSTANT_EXPRESSION_RESULT were generated without it. For byte types,
//! size never exceeded ELEMS_MAX but the code was not removed.
//! \note size is the count of elements, and not the number of bytes
static void CheckSize(size_t size)
{
// C++ throws std::bad_alloc (C++03) or std::bad_array_new_length (C++11) here.
if (size > ELEMS_MAX)
if (sizeof(T) != 1 && size > ELEMS_MAX)
throw InvalidArgument("AllocatorBase: requested size would cause integer overflow");
}
};