shadps4-emu/ext-cryptopp
1
0
Fork 0
mirror of https://github.com/shadps4-emu/ext-cryptopp.git synced 2024-11-27 03:40:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coverity finding CID 147829 Bad bit shift operation (BAD_SHIFT)

Browse Source 
I'm fairly certian this is a false positive. Checking GF2NT::MultiplicativeInverse under code coverage shows its exercised 555,735 times. We will clear it anayway to squash the finding
For those not aware, on Linux and Unix, you can issue 'make coverage' and get code coverage statistics
This commit is contained in:
Jeffrey Walton 2016-09-27 20:20:54 -04:00
parent c3e45b2e51
commit 8d227675a9
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gf2n.cpp
View File

@ -717,8 +717,11 @@ const GF2NT::Element& GF2NT::MultiplicativeInverse(const Element &a) const
for (unsigned int j=0; j<WORD_BITS-t1; j++) for (unsigned int j=0; j<WORD_BITS-t1; j++)
{ {
// Coverity finding on shift amount of 'word x << (t1+j)'. // Coverity finding on shift amount of 'word x << (t1+j)'.
// temp ^= ((temp >> j) & 1) << (t1 + j);
CRYPTOPP_ASSERT(t1+j < WORD_BITS); CRYPTOPP_ASSERT(t1+j < WORD_BITS);
temp ^= ((temp >> j) & 1) << (t1 + j); const unsigned int shift = t1 + j;
temp ^= ((shift >= WORD_BITS) ? 0 : ((temp >> j) & 1) << shift);
} }
} }
else else