shadps4-emu/ext-cryptopp
1
0
Fork 0
mirror of https://github.com/shadps4-emu/ext-cryptopp.git synced 2025-02-21 13:53:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update comments

Browse Source
This commit is contained in:
Jeffrey Walton 2021-03-20 19:17:45 -04:00
parent f845316e95
commit a73d83c881
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
datatest.cpp
View File

@ -1304,17 +1304,21 @@ void TestDataFile(std::string filename, const NameValuePairs &overrideParameters
}
}
// Most tests fully specify parameters, like key and iv. Each test gets
// its own unique value. Since each test gets a new value for each test
// case, latching a value in 'TestData v' does not matter. The old key
// or iv will get overwritten on the next test.
//
// If a per-test vector parameter was set for a test, like BlockPadding,
// BlockSize or Tweak, then it becomes latched in testDataPairs. The old
// BlockSize or Tweak, then it becomes latched in 'TestData v'. The old
// value is used in subsequent tests, and it could cause a self test
// failure in the next test. The behavior surfaced under Kalyna and
// Threefish. The Kalyna test vectors use NO_PADDING for all tests except
// one. For Threefish, using (and not using) a Tweak caused problems as
// we marched through test vectors. For BlockPadding, BlockSize or Tweak,
// unlatch them now, after the key has been set and NameValuePairs have
// been processed. Also note we only unlatch from testDataPairs. If
// overrideParameters are specified, the caller is responsible for
// managing the parameter.
// one. Threefish occasionally use a Tweak.
//
// Unlatch BlockPadding, BlockSize and Tweak now, after the test has been
// run. Also note we only unlatch from 'TestData v'. If overrideParameters
// are specified, the caller is responsible for managing the parameter.
v.erase("Tweak"); v.erase("InitialBlock");
v.erase("BlockSize"); v.erase("BlockPaddingScheme");
}