Fix Clang warning on missing template definitions

bench2.cpp

@@ -8,6 +8,7 @@
 #include "pubkey.h"
 #include "gfpcrypt.h"
 #include "eccrypto.h"
+#include "pkcspad.h"
 
 #include "files.h"
 #include "filters.h"

dll.cpp

@@ -6,6 +6,7 @@
 #include "dll.h"
 #include "config.h"
 #include "iterhash.h"
+#include "pkcspad.h"
 
 // Cast from FARPROC to funcptr with args, http://stackoverflow.com/q/4192058/608639
 #pragma warning(disable: 4191)

dlltest.cpp

@@ -5,6 +5,7 @@
 #include "dll.h"
 #include "cryptlib.h"
 #include "filters.h"
+#include "pkcspad.h"
 
 #if CRYPTOPP_MSC_VERSION
 # pragma warning(disable: 4505 4355)

fipstest.cpp

@@ -10,6 +10,7 @@
 #include "cryptlib.h"
 #include "filters.h"
 #include "smartptr.h"
+#include "pkcspad.h"
 #include "misc.h"
 
 // Simply disable CRYPTOPP_WIN32_AVAILABLE for Windows Phone and Windows Store apps

luc.cpp

@@ -7,6 +7,7 @@
 #include "integer.h"
 #include "nbtheory.h"
 #include "algparam.h"
+#include "pkcspad.h"
 
 NAMESPACE_BEGIN(CryptoPP)
 

pkcspad.h

@@ -53,12 +53,19 @@ class MD5;
 }
 // end of list
 
-#ifdef CRYPTOPP_IS_DLL
+#if defined(CRYPTOPP_IS_DLL)
 CRYPTOPP_DLL_TEMPLATE_CLASS PKCS_DigestDecoration<SHA1>;
 CRYPTOPP_DLL_TEMPLATE_CLASS PKCS_DigestDecoration<SHA224>;
 CRYPTOPP_DLL_TEMPLATE_CLASS PKCS_DigestDecoration<SHA256>;
 CRYPTOPP_DLL_TEMPLATE_CLASS PKCS_DigestDecoration<SHA384>;
 CRYPTOPP_DLL_TEMPLATE_CLASS PKCS_DigestDecoration<SHA512>;
+#elif defined(__clang__)
+// Provide a default definition to avoid Clang warnings. CRTP will provide a
+// real definition later. The single element is due to MSVC compile failures
+// after adding the default definition. However, GCC produces multiple
+// definitions which result in link failures. I give up...
+template <class H>
+const byte PKCS_DigestDecoration<H>::decoration[1] = {0x00};
 #endif
 
 //! \class PKCS1v15_SignatureMessageEncodingMethod

rsa.cpp

@@ -9,6 +9,7 @@
 #include "nbtheory.h"
 #include "algparam.h"
 #include "fips140.h"
+#include "pkcspad.h"
 
 #if defined(CRYPTOPP_DEBUG) && !defined(CRYPTOPP_DOXYGEN_PROCESSING) && !defined(CRYPTOPP_IS_DLL)
 #include "pssr.h"

test.cpp

@@ -24,6 +24,7 @@
 #include "whrlpool.h"
 #include "tiger.h"
 #include "smartptr.h"
+#include "pkcspad.h"
 #include "stdcpp.h"
 #include "ossig.h"
 #include "trap.h"

validat2.cpp

@@ -39,6 +39,7 @@
 #include "sha.h"
 #include "ripemd.h"
 #include "smartptr.h"
+#include "pkcspad.h"
 
 #include <iostream>
 #include <sstream>