stoatchat/for-web
1
0
Fork 0
mirror of https://github.com/stoatchat/for-web.git synced 2026-07-21 15:15:21 -04:00
Code Issues 226 Packages Projects Releases 10 Wiki Activity

[PR #349] [MERGED] fix: Update line height for small labels so text is not cut off #609

New Issue
Closed
opened 2026-02-16 12:36:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 12:36:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/for-web/pull/349
Author: @amazingca
Created: 3/7/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @insertish

Base: main ← Head: amazingca/interface/OverflowingText-unset-height

📝 Commits (3)

  • a72b9ff fix: Modify line height to unset in OverflowingText.tsx
  • 3062000 fix: Move height attribute to according specification in Typography.tsx
  • ff75a20 fix: Increase line height to account for lowercase-g's

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/client/components/ui/components/design/atoms/display/Typography.tsx (+1 -1)

📄 Description

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

Brief synopsis of the fix:

Before:
Screenshot 2025-03-07 at 2 18 07 PM

After:
Screenshot 2025-03-07 at 3 09 40 PM

On a side note, this is my first attempt at a contribution to this repository, so please let me know if these types of contributions are acceptable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/for-web/pull/349 **Author:** [@amazingca](https://github.com/amazingca) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@insertish](https://github.com/insertish) **Base:** `main` ← **Head:** `amazingca/interface/OverflowingText-unset-height` --- ### 📝 Commits (3) - [`a72b9ff`](https://github.com/stoatchat/for-web/commit/a72b9ffe3f232e490df517b0dfbebd8ffa31d2a1) fix: Modify line height to unset in OverflowingText.tsx - [`3062000`](https://github.com/stoatchat/for-web/commit/30620005772ba70bf15444c6f91278ef02b57841) fix: Move height attribute to according specification in Typography.tsx - [`ff75a20`](https://github.com/stoatchat/for-web/commit/ff75a20fa758d5f816a38242b53b047e7f6bde66) fix: Increase line height to account for lowercase-g's ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/client/components/ui/components/design/atoms/display/Typography.tsx` (+1 -1) </details> ### 📄 Description ## Please make sure to check the following tasks before opening and submitting a PR - [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [x] I have tested my changes locally and they are working as intended ### Brief synopsis of the fix: > **Before:** > ![Screenshot 2025-03-07 at 2 18 07 PM](https://github.com/user-attachments/assets/aaa09263-96e9-4178-af0e-29b2c0cde160) > **After:** > ![Screenshot 2025-03-07 at 3 09 40 PM](https://github.com/user-attachments/assets/9e96043c-b0b1-477f-8b86-9d2882a56ccc) On a side note, this is my first attempt at a contribution to this repository, so please let me know if these types of contributions are acceptable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:36:04 -05:00
yindo closed this issue 2026-02-16 12:36:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
improvement
improvement
improvement
needs design
pull-request
Mirrored from GitHub Pull Request
 ux review
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/for-web#609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?