stoatchat/for-web
1
0
Fork 0
mirror of https://github.com/stoatchat/for-web.git synced 2026-07-21 15:15:21 -04:00
Code Issues 226 Packages Projects Releases 10 Wiki Activity

[PR #360] [CLOSED] fix: Check for already-opened modal to prevent duplicates #613

New Issue
Closed
opened 2026-02-16 12:36:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 12:36:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/for-web/pull/360
Author: @amazingca
Created: 4/27/2025
Status: ❌ Closed

Base: main ← Head: Home-update-modal-pushing

📝 Commits (1)

  • c891ca4 fix: Check for already-opened modal to prevent duplicates

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 packages/client/components/modal/index.tsx (+9 -3)

📄 Description

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

Summary of change

This is a proposed change to the ModalController that fixes the issue described in #359.

As I mentioned in the issue, I am not sure whether this is the most viable solution as there might be something happening to cause this which I am not aware of. Regardless, if there any questions feel free to let me know.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/for-web/pull/360 **Author:** [@amazingca](https://github.com/amazingca) **Created:** 4/27/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Home-update-modal-pushing` --- ### 📝 Commits (1) - [`c891ca4`](https://github.com/stoatchat/for-web/commit/c891ca4d0252d347cabea85312c03e71eeb5f48a) fix: Check for already-opened modal to prevent duplicates ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/client/components/modal/index.tsx` (+9 -3) </details> ### 📄 Description ## Please make sure to check the following tasks before opening and submitting a PR - [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [x] I have tested my changes locally and they are working as intended ## Summary of change This is a proposed change to the ModalController that fixes the issue described in #359. As I mentioned in the issue, I am not sure whether this is the most viable solution as there might be something happening to cause this which I am not aware of. Regardless, if there any questions feel free to let me know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:36:04 -05:00
yindo closed this issue 2026-02-16 12:36:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
improvement
improvement
improvement
needs design
pull-request
Mirrored from GitHub Pull Request
 ux review
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/for-web#613
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?