[PR #36] [CLOSED] FIX: Handle empty response bodies #34

New Issue

Closed

opened 2026-02-16 12:29:02 -05:00 by yindo · 0 comments

yindo commented 2026-02-16 12:29:02 -05:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-api/pull/36
Author: @ghost
Created: 8/25/2025
Status: ❌ Closed

Base: main ← Head: patch-1

---

📝 Commits (1)

• 8699571 FIX: Handle empty response bodies

📊 Changes

1 file changed (+20 additions, -1 deletions)

View changed files

📝 src/index.ts (+20 -1)

📄 Description

Previously, the API client would throw a JSON parse error if a response body was empty, this checks for that and handles it without throwing an error – fixes the bug reported on frontend repo here

Please make sure to check the following tasks before opening and submitting a PR

• I understand and have followed the contribution guide
• I have tested my changes locally and they are working as intended
  ↑ Unable to test it locally

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-api/pull/36 **Author:** [@ghost](https://github.com/ghost) **Created:** 8/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`8699571`](https://github.com/stoatchat/javascript-client-api/commit/8699571d853ca890d63860e134644e284a82eb07) FIX: Handle empty response bodies ### 📊 Changes **1 file changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/index.ts` (+20 -1) </details> ### 📄 Description Previously, the API client would throw a JSON parse error if a response body was empty, this checks for that and handles it without throwing an error – fixes the bug reported on frontend repo [here](https://github.com/revoltchat/frontend/issues/418) ## Please make sure to check the following tasks before opening and submitting a PR - [X] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [ ] I have tested my changes locally and they are working as intended ↑ Unable to test it locally --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

yindo added the pull-request label 2026-02-16 12:29:02 -05:00

yindo closed this issue 2026-02-16 12:29:02 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

next

0.15.2

0.15.1

0.14.3

0.14.2

0.14.1

0.14.0

0.13.7

0.13.6

0.12.0

0.11.5

0.11.0

0.10.3

0.10.1

0.9.4

0.8.9-3

0.8.9-2

0.8.9-1

0.8.9

0.8.8

0.8.7

0.8.6

0.8.5

0.8.4

0.8.3

0.8.2

0.8.1

0.8.0

0.7.16

0.7.15

0.7.14

0.7.13

0.7.12

0.7.11

0.7.10

0.7.9

0.7.8

0.7.7

0.7.6

0.7.5

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.13

0.6.12

0.6.9

0.6.8

0.6.7

0.6.6

0.6.5

0.6.4

0.6.3

0.6.2

0.6.1

0.6.0

0.6.0-rc.2

0.5.21

0.5.20

0.5.19

0.5.18

0.5.17

0.5.16

0.5.15

0.5.14

0.5.13

0.5.12

0.5.11

0.5.10

0.5.9

0.5.8

Labels

Clear labels

bug

bug

duplicate

enhancement

improvement

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

yindo

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-api#34