From c332974d90b4fca3aa5a55bd5ab998caefd648e4 Mon Sep 17 00:00:00 2001
From: Paul Makles <me@insrt.uk>
Date: Thu, 28 Nov 2024 13:16:30 +0000
Subject: [PATCH] fix: need to also convert to JS object

---
 src/events/v1.ts | 26 +++++++-------------------
 1 file changed, 7 insertions(+), 19 deletions(-)

diff --git a/src/events/v1.ts b/src/events/v1.ts
index 71ccbae7..0fb10f32 100644
--- a/src/events/v1.ts
+++ b/src/events/v1.ts
@@ -3,7 +3,6 @@ import { Setter, batch } from "solid-js";
 import { ReactiveSet } from "@solid-primitives/set";
 import type {
   Channel,
-  Embed,
   Emoji,
   Error,
   FieldsChannel,
@@ -20,7 +19,7 @@ import type {
 } from "revolt-api";
 
 import { hydrate } from "../hydration/index.js";
-import { Client } from "../index.js";
+import { Client, MessageEmbed } from "../index.js";
 
 /**
  * Version 1 of the events protocol
@@ -180,17 +179,6 @@ type ReadyData = {
   emojis: Emoji[];
 };
 
-/**
- * Websocket error packet
- */
-type WebSocketError = {
-  error:
-    | "InternalError"
-    | "InvalidSession"
-    | "OnboardingNotFinished"
-    | "AlreadyAuthenticated";
-};
-
 /**
  * Handle an event for the Client
  * @param client Client
@@ -307,12 +295,12 @@ export async function handleEvent(
           channelId: event.channel,
         };
 
-        client.messages.updateUnderlyingObject(
-          event.id,
-          "embeds",
-          (embeds) =>
-            [...(embeds ?? []), ...(event.append.embeds ?? [])] as Embed[]
-        );
+        client.messages.updateUnderlyingObject(event.id, "embeds", (embeds) => [
+          ...(embeds ?? []),
+          ...(event.append.embeds?.map((embed) =>
+            MessageEmbed.from(client, embed)
+          ) ?? []),
+        ]);
 
         client.messages.updateUnderlyingObject(
           event.id,