[PR #119] [MERGED] fix: increase typing timeout to 4s #115

New Issue

2026-02-16T12:27:03-05:00

yindo commented

2026-02-16 12:27:03 -05:00

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/119
Author: @Aeledfyr
Created: 9/30/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @insertish

Base: main ← Head: main

📝 Commits (1)

56926ad fix: increase typing timeout to 4s

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/events/v1.ts (+1 -1)

📄 Description

The frontend only sends typing updates every 2.5-3s, so the 1s timeout caused the typing indicator to flicker.

Note that the typing indicators still have some flickering, but it should only be when the user's client sent a StopTyping event, so the source of the flicker is in the sender's typing detection heuristics.

(Given the timeout, I'm not sure if StopTyping events are necessary before a message is actually sent -- would it be simpler to have CurrentlyTyping events with a timeout, and cancel the indicator on the next received message from that user?)

Please make sure to check the following tasks before opening and submitting a PR

I understand and have followed the contribution guide
I have tested my changes locally and they are working as intended

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/119 **Author:** [@Aeledfyr](https://github.com/Aeledfyr) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@insertish](https://github.com/insertish) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`56926ad`](https://github.com/stoatchat/javascript-client-sdk/commit/56926ad03278999a5956861276fd7beb37081d8a) fix: increase typing timeout to 4s ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/events/v1.ts` (+1 -1) </details> ### 📄 Description The frontend only sends typing updates every 2.5-3s, so the 1s timeout caused the typing indicator to flicker. Note that the typing indicators still have some flickering, but it should only be when the user's client sent a StopTyping event, so the source of the flicker is in the sender's typing detection heuristics. (Given the timeout, I'm not sure if StopTyping events are necessary before a message is actually sent -- would it be simpler to have CurrentlyTyping events with a timeout, and cancel the indicator on the next received message from that user?) ## Please make sure to check the following tasks before opening and submitting a PR - [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [x] I have tested my changes locally and they are working as intended --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 12:27:03 -05:00

yindo closed this issue

2026-02-16 12:27:03 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#115