[PR #114] [CLOSED] BREAKING: remove solid.js dependency and redo collection interface #116

New Issue

2026-02-16T12:27:03-05:00

yindo commented

2026-02-16 12:27:03 -05:00

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/114
Author: @williamhorning
Created: 3/14/2025
Status: ❌ Closed

Base: main ← Head: bye-bye-solid

📝 Commits (8)

02a5413 BREAKING CHANGE: remove solid.js dependency and redo collection interface
78e7367 remove solid.js from package.json
7b3899e Merge remote-tracking branch 'upstream/main' into bye-bye-solid
6738be5 fix lockfile
a354071 quick little fix
b2008e9 Merge branch 'main' into bye-bye-solid
1747142 Merge branch 'main' into bye-bye-solid
c3547da fix lockfile

📊 Changes

33 files changed (+383 additions, -709 deletions)

View changed files

📝 .vscode/settings.json (+4 -1)
📝 eslint.config.js (+0 -2)
📝 package.json (+1 -5)
📝 pnpm-lock.yaml (+9 -140)
📝 src/Client.ts (+15 -24)
📝 src/classes/Channel.ts (+27 -38)
📝 src/classes/ChannelUnread.ts (+1 -3)
📝 src/classes/ChannelWebhook.ts (+1 -1)
📝 src/classes/MFA.ts (+17 -11)
📝 src/classes/Message.ts (+1 -3)
📝 src/classes/PublicInvite.ts (+9 -13)
📝 src/classes/Server.ts (+42 -56)
📝 src/classes/Session.ts (+1 -1)
📝 src/classes/User.ts (+1 -1)
📝 src/collections/BotCollection.ts (+4 -10)
📝 src/collections/ChannelCollection.ts (+2 -5)
📝 src/collections/ChannelUnreadCollection.ts (+9 -11)
📝 src/collections/ChannelWebhookCollection.ts (+2 -2)
📝 src/collections/Collection.ts (+87 -132)
📝 src/collections/EmojiCollection.ts (+2 -2)

...and 13 more files

📄 Description

this removes all of the solid.js dependencies from revolt.js. the majority of the consumers of the library are bots which don't need or use any of these primitives. this does break frontend, though, so don't merge this right away please

I understand and have followed the contribution guide
I have tested my changes locally and they are working as intended

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/114 **Author:** [@williamhorning](https://github.com/williamhorning) **Created:** 3/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bye-bye-solid` --- ### 📝 Commits (8) - [`02a5413`](https://github.com/stoatchat/javascript-client-sdk/commit/02a541339d22c836adf7ed27a51d000817dfc149) BREAKING CHANGE: remove solid.js dependency and redo collection interface - [`78e7367`](https://github.com/stoatchat/javascript-client-sdk/commit/78e736795e2fb5441db5a7fdaf5c7acb793c8326) remove solid.js from package.json - [`7b3899e`](https://github.com/stoatchat/javascript-client-sdk/commit/7b3899e8473a2d3046a0d3600bdf8dab38ac88a3) Merge remote-tracking branch 'upstream/main' into bye-bye-solid - [`6738be5`](https://github.com/stoatchat/javascript-client-sdk/commit/6738be5d9a95fa5532ce7cf40224c5de4c005ca8) fix lockfile - [`a354071`](https://github.com/stoatchat/javascript-client-sdk/commit/a3540711f4c0bfce544e418862bb36d16f69a40c) quick little fix - [`b2008e9`](https://github.com/stoatchat/javascript-client-sdk/commit/b2008e9efcfbf765e2c2c49edb46fcf6015fa0dd) Merge branch 'main' into bye-bye-solid - [`1747142`](https://github.com/stoatchat/javascript-client-sdk/commit/17471425fe2934c07a68d7ed1a8e442ebf3ffe35) Merge branch 'main' into bye-bye-solid - [`c3547da`](https://github.com/stoatchat/javascript-client-sdk/commit/c3547da1065a8067b4d09a4621fd3637b0bb6c5a) fix lockfile ### 📊 Changes **33 files changed** (+383 additions, -709 deletions) <details> <summary>View changed files</summary> 📝 `.vscode/settings.json` (+4 -1) 📝 `eslint.config.js` (+0 -2) 📝 `package.json` (+1 -5) 📝 `pnpm-lock.yaml` (+9 -140) 📝 `src/Client.ts` (+15 -24) 📝 `src/classes/Channel.ts` (+27 -38) 📝 `src/classes/ChannelUnread.ts` (+1 -3) 📝 `src/classes/ChannelWebhook.ts` (+1 -1) 📝 `src/classes/MFA.ts` (+17 -11) 📝 `src/classes/Message.ts` (+1 -3) 📝 `src/classes/PublicInvite.ts` (+9 -13) 📝 `src/classes/Server.ts` (+42 -56) 📝 `src/classes/Session.ts` (+1 -1) 📝 `src/classes/User.ts` (+1 -1) 📝 `src/collections/BotCollection.ts` (+4 -10) 📝 `src/collections/ChannelCollection.ts` (+2 -5) 📝 `src/collections/ChannelUnreadCollection.ts` (+9 -11) 📝 `src/collections/ChannelWebhookCollection.ts` (+2 -2) 📝 `src/collections/Collection.ts` (+87 -132) 📝 `src/collections/EmojiCollection.ts` (+2 -2) _...and 13 more files_ </details> ### 📄 Description this removes all of the `solid.js` dependencies from revolt.js. the majority of the consumers of the library are bots which don't need or use any of these primitives. this does break frontend, though, so don't merge this right away please --- - [X] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [X] I have tested my changes locally and they are working as intended --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 12:27:03 -05:00

yindo closed this issue

2026-02-16 12:27:03 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#116