stoatchat/javascript-client-sdk
1
0
Fork 0
mirror of https://github.com/stoatchat/javascript-client-sdk.git synced 2026-07-21 04:25:27 -04:00
Code Issues 9 Packages Projects Releases 6 Wiki Activity

[PR #122] [MERGED] fix: missing undefined check on policy_changes #118

New Issue
Closed
opened 2026-02-16 12:27:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 12:27:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/122
Author: @amycatgirl
Created: 11/17/2025
Status: ✅ Merged
Merged: 1/1/2026
Merged by: @reeesespuffs

Base: main ← Head: fix/missing-policy

📝 Commits (2)

  • 83b3be3 feat: add nix shell
  • 74e02d4 fix: missing undefined check in policy_changes

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

➕ default.nix (+19 -0)
📝 src/events/v1.ts (+1 -1)

📄 Description

Bots do not receive policy changes on their ready event because they do not have to ACK new changes like users do. However, the event handler code does not check for this and causes bots using stoat.js to crash.

This PR is stacked on top of #121

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/122 **Author:** [@amycatgirl](https://github.com/amycatgirl) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 1/1/2026 **Merged by:** [@reeesespuffs](https://github.com/reeesespuffs) **Base:** `main` ← **Head:** `fix/missing-policy` --- ### 📝 Commits (2) - [`83b3be3`](https://github.com/stoatchat/javascript-client-sdk/commit/83b3be3c48fafb3f0fcd2d3dbd72db1ccc34db60) feat: add nix shell - [`74e02d4`](https://github.com/stoatchat/javascript-client-sdk/commit/74e02d4359ee80b0ebd5f1092faee344c9fb66af) fix: missing undefined check in policy_changes ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `default.nix` (+19 -0) 📝 `src/events/v1.ts` (+1 -1) </details> ### 📄 Description Bots do not receive policy changes on their ready event because they do not have to ACK new changes like users do. However, the event handler code does not check for this and causes bots using stoat.js to crash. This PR is stacked on top of #121 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:27:04 -05:00
yindo closed this issue 2026-02-16 12:27:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?