stoatchat/javascript-client-sdk
1
0
Fork 0
mirror of https://github.com/stoatchat/javascript-client-sdk.git synced 2026-07-18 16:34:27 -04:00
Code Issues 9 Packages Projects Releases 6 Wiki Activity

[PR #123] [MERGED] fix: make ReadyData partial to match event documentation #120

New Issue
Closed
opened 2026-02-16 12:27:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 12:27:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/123
Author: @amycatgirl
Created: 1/16/2026
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @reeesespuffs

Base: main ← Head: fix/ready-partial

📝 Commits (1)

  • 38af805 fix: make ReadyData partial to match event documentation

📊 Changes

1 file changed (+141 additions, -130 deletions)

View changed files

📝 src/events/v1.ts (+141 -130)

📄 Description

See: https://github.com/stoatchat/javascript-client-sdk/pull/122#issuecomment-3759902589

This should actually fix bots crashing when receiving the Ready event without policy_changes, it also makes the ReadyData type (which contains the field definitions for what the event returns) partial.

The reason why there are so many additions is because I ran prettier to format the file

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/123 **Author:** [@amycatgirl](https://github.com/amycatgirl) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@reeesespuffs](https://github.com/reeesespuffs) **Base:** `main` ← **Head:** `fix/ready-partial` --- ### 📝 Commits (1) - [`38af805`](https://github.com/stoatchat/javascript-client-sdk/commit/38af805cd014fbbc7c27db00b77187e003181cc6) fix: make ReadyData partial to match event documentation ### 📊 Changes **1 file changed** (+141 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `src/events/v1.ts` (+141 -130) </details> ### 📄 Description See: https://github.com/stoatchat/javascript-client-sdk/pull/122#issuecomment-3759902589 This should actually fix bots crashing when receiving the `Ready` event without `policy_changes`, it also makes the `ReadyData` type (which contains the field definitions for what the event returns) partial. The reason why there are so many additions is because I ran prettier to format the file --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:27:04 -05:00
yindo closed this issue 2026-02-16 12:27:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?