[PR #35] [MERGED] Declare index typings #63

Closed
opened 2026-02-16 12:26:56 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/35
Author: @NightScript370
Created: 1/19/2022
Status: Merged
Merged: 4/24/2022
Merged by: @insertish

Base: masterHead: master


📝 Commits (2)

  • eb9530b Add main typings declaration
  • 8e080f5 Merge branch 'master' into master

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 package.json (+1 -0)

📄 Description

https://docs.skypack.dev/package-authors/package-checks#types

Getting typings called by skypack allows Deno users wishing to use revolt.js to see the typings.
This doesn't close my issue but it does work around the issue. We should still see if we could make a Deno compatible build by default rather than rely on this third party app but it works.

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package
It's also what the TypeScript specifications recommend


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/35 **Author:** [@NightScript370](https://github.com/NightScript370) **Created:** 1/19/2022 **Status:** ✅ Merged **Merged:** 4/24/2022 **Merged by:** [@insertish](https://github.com/insertish) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`eb9530b`](https://github.com/stoatchat/javascript-client-sdk/commit/eb9530b346f9b5b3ebecfa7c6c5171e1af64a70f) Add main typings declaration - [`8e080f5`](https://github.com/stoatchat/javascript-client-sdk/commit/8e080f5007d0844165f7bfefe843db16da78f0f3) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -0) </details> ### 📄 Description https://docs.skypack.dev/package-authors/package-checks#types Getting typings called by skypack allows Deno users wishing to use revolt.js to see the typings. This doesn't close my issue but it does work around the issue. We should still see if we could make a Deno compatible build by default rather than rely on this third party app but it works. https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package It's also what the TypeScript specifications recommend --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:26:56 -05:00
yindo closed this issue 2026-02-16 12:26:56 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#63