[PR #60] [MERGED] fix: move the Session type to Client.ts #80

New Issue

2026-02-16T12:26:58-05:00

yindo commented

2026-02-16 12:26:58 -05:00

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/60
Author: @Rexogamer
Created: 9/4/2022
Status: ✅ Merged
Merged: 11/9/2022
Merged by: @insertish

Base: master ← Head: globals-fix

📝 Commits (2)

254bb3d fix: move the Session type to Client.ts
fb65be6 Merge branch 'revoltchat:master' into globals-fix

📊 Changes

3 files changed (+3 additions, -1 deletions)

View changed files

📝 src/Client.ts (+2 -0)
📝 src/globals.d.ts (+0 -1)
📝 src/websocket/notifications.ts (+1 -0)

📄 Description

Please make sure to check the following tasks before opening and submitting a PR

I understand and have followed the contribution guide
I have tested my changes locally and they are working as intended
These changes do not have any notable side effects on other Revolt projects

This PR moves the Session type to Client.ts, fixing an issue where the type wouldn't be available in built versions of revolt.js (Globals.d.ts wasn't included in them).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/60 **Author:** [@Rexogamer](https://github.com/Rexogamer) **Created:** 9/4/2022 **Status:** ✅ Merged **Merged:** 11/9/2022 **Merged by:** [@insertish](https://github.com/insertish) **Base:** `master` ← **Head:** `globals-fix` --- ### 📝 Commits (2) - [`254bb3d`](https://github.com/stoatchat/javascript-client-sdk/commit/254bb3d1d1d1632a871a583f3b509f7548d0f025) fix: move the Session type to Client.ts - [`fb65be6`](https://github.com/stoatchat/javascript-client-sdk/commit/fb65be657034025b80cbdca42841fe4fe688cbe8) Merge branch 'revoltchat:master' into globals-fix ### 📊 Changes **3 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Client.ts` (+2 -0) 📝 `src/globals.d.ts` (+0 -1) 📝 `src/websocket/notifications.ts` (+1 -0) </details> ### 📄 Description ## Please make sure to check the following tasks before opening and submitting a PR * [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/revolt/discussions/282) * [x] I have tested my changes locally and they are working as intended * [x] These changes do not have any notable side effects on other Revolt projects This PR moves the `Session` type to `Client.ts`, fixing an issue where the type wouldn't be available in built versions of revolt.js (`Globals.d.ts` wasn't included in them). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 12:26:58 -05:00

yindo closed this issue

2026-02-16 12:26:58 -05:00

yindo referenced this issue

2026-02-16 12:27:00 -05:00

[PR #80] [MERGED] fix types #90

yindo referenced this issue

2026-02-16 12:27:00 -05:00

[PR #84] [MERGED] fix: allow explicit ESM import #92

Sign in to join this conversation.