stoatchat/javascript-client-sdk
1
0
Fork 0
mirror of https://github.com/stoatchat/javascript-client-sdk.git synced 2026-07-20 20:16:06 -04:00
Code Issues 9 Packages Projects Releases 6 Wiki Activity

[PR #94] [MERGED] feat: add deleteEmoji method to Server class #98

New Issue
Closed
opened 2026-02-16 12:27:01 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 12:27:01 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/94
Author: @xibn
Created: 2/24/2024
Status: ✅ Merged
Merged: 6/8/2024
Merged by: @insertish

Base: master ← Head: patch-1

📝 Commits (1)

  • 72a831d Added deleteEmoji method to the Server class.

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 src/classes/Server.ts (+10 -0)

📄 Description

This should fix issue #86 by adding the deleteEmoji method to the Server class. I went with the usual pattern used for deleting. I also tried to make the code style fit into Server.ts's already existing style of code.

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended
  • These changes do not have any notable side effects on other Revolt projects

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/94 **Author:** [@xibn](https://github.com/xibn) **Created:** 2/24/2024 **Status:** ✅ Merged **Merged:** 6/8/2024 **Merged by:** [@insertish](https://github.com/insertish) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`72a831d`](https://github.com/stoatchat/javascript-client-sdk/commit/72a831df947f0e2d0f64e00e2b10b4acd73d586d) Added deleteEmoji method to the Server class. ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/classes/Server.ts` (+10 -0) </details> ### 📄 Description This should fix issue #86 by adding the deleteEmoji method to the Server class. I went with the usual pattern used for deleting. I also tried to make the code style fit into Server.ts's already existing style of code. ## Please make sure to check the following tasks before opening and submitting a PR * [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/revolt/discussions/282) * [x] I have tested my changes locally and they are working as intended * [x] These changes do not have any notable side effects on other Revolt projects --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:27:01 -05:00
yindo closed this issue 2026-02-16 12:27:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#98
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?