[PR #97] [MERGED] fix: channelId on messageUpdate & honour partial objects #99

New Issue

2026-02-16T12:27:01-05:00

yindo commented

2026-02-16 12:27:01 -05:00

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/97
Author: @austinhuang0131
Created: 6/4/2024
Status: ✅ Merged
Merged: 6/8/2024
Merged by: @insertish

Base: master ← Head: master

📝 Commits (3)

fe325e3 fix: add channelId on MessageUpdate and MessageAppend
3ffa0e7 fix: do not hydrate partial property
16b1e60 fix: fetch should fill out partial objects

📊 Changes

9 files changed (+40 additions, -13 deletions)

View changed files

📝 src/collections/ChannelCollection.ts (+2 -2)
📝 src/collections/EmojiCollection.ts (+2 -2)
📝 src/collections/MessageCollection.ts (+2 -2)
📝 src/collections/ServerCollection.ts (+2 -2)
📝 src/collections/ServerMemberCollection.ts (+11 -2)
📝 src/collections/UserCollection.ts (+2 -2)
📝 src/events/v1.ts (+13 -1)
📝 src/hydration/index.ts (+5 -0)
📝 src/storage/ObjectStorage.ts (+1 -0)

📄 Description

https://github.com/revoltchat/revolt.js/commit/fe325e3628fb056591ad89fc9da4dbf08109a067 adds channel ID (which is supplied by the event) onto partial messages, for those who enabled partials in ClientOptions.
https://github.com/revoltchat/revolt.js/commit/3ffa0e79e7f0fed6caeb4711c0542be9cdd7d9a8 makes partial properties actually persist in storage (otherwise isPartial is useless).
https://github.com/revoltchat/revolt.js/commit/16b1e60cb2a402d6c9d015fdffdf796b36d6d6be allows partial objects to be converted to full objects whenever the respective fetch methods are called.

Please make sure to check the following tasks before opening and submitting a PR

I understand and have followed the contribution guide
I have tested my changes locally and they are working as intended

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/97 **Author:** [@austinhuang0131](https://github.com/austinhuang0131) **Created:** 6/4/2024 **Status:** ✅ Merged **Merged:** 6/8/2024 **Merged by:** [@insertish](https://github.com/insertish) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`fe325e3`](https://github.com/stoatchat/javascript-client-sdk/commit/fe325e3628fb056591ad89fc9da4dbf08109a067) fix: add channelId on MessageUpdate and MessageAppend - [`3ffa0e7`](https://github.com/stoatchat/javascript-client-sdk/commit/3ffa0e79e7f0fed6caeb4711c0542be9cdd7d9a8) fix: do not hydrate partial property - [`16b1e60`](https://github.com/stoatchat/javascript-client-sdk/commit/16b1e60cb2a402d6c9d015fdffdf796b36d6d6be) fix: fetch should fill out partial objects ### 📊 Changes **9 files changed** (+40 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/collections/ChannelCollection.ts` (+2 -2) 📝 `src/collections/EmojiCollection.ts` (+2 -2) 📝 `src/collections/MessageCollection.ts` (+2 -2) 📝 `src/collections/ServerCollection.ts` (+2 -2) 📝 `src/collections/ServerMemberCollection.ts` (+11 -2) 📝 `src/collections/UserCollection.ts` (+2 -2) 📝 `src/events/v1.ts` (+13 -1) 📝 `src/hydration/index.ts` (+5 -0) 📝 `src/storage/ObjectStorage.ts` (+1 -0) </details> ### 📄 Description * https://github.com/revoltchat/revolt.js/commit/fe325e3628fb056591ad89fc9da4dbf08109a067 adds channel ID (which is supplied by the event) onto partial messages, for those who enabled `partials` in [ClientOptions](https://revolt.js.org/types/ClientOptions.html). * https://github.com/revoltchat/revolt.js/commit/3ffa0e79e7f0fed6caeb4711c0542be9cdd7d9a8 makes partial properties actually persist in storage (otherwise `isPartial` is useless). * https://github.com/revoltchat/revolt.js/commit/16b1e60cb2a402d6c9d015fdffdf796b36d6d6be allows partial objects to be converted to full objects whenever the respective fetch methods are called. ## Please make sure to check the following tasks before opening and submitting a PR - [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [x] I have tested my changes locally and they are working as intended --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 12:27:01 -05:00

yindo closed this issue

2026-02-16 12:27:01 -05:00

yindo referenced this issue

2026-02-16 12:27:01 -05:00

[PR #99] [MERGED] chore(deps): bump follow-redirects from 1.15.2 to 1.15.6 #101

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#99