[PR #63] [MERGED] Fix the 'user' and 'remove_all' parameters not working in Message#remove_reaction() #83

New Issue

2026-02-15T23:16:35-05:00

yindo commented

2026-02-15 23:16:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/stoatchat/python-client-sdk/pull/63
Author: @Solarphlare
Created: 7/9/2023
Status: ✅ Merged
Merged: 7/19/2023
Merged by: @Zomatree

Base: master ← Head: master

📝 Commits (2)

2f63f7c Fix parameters not being passed in remove_reaction
cf9634f Update revolt/http.py

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 revolt/http.py (+1 -1)

📄 Description

The parameters dict containing user_id and remove_all are never passed to the request function, so attempting to remove a specific user's reactions or all reactions of a particular emoji will not work. This PR rectifies the issue by passing the parameters dict to the request function.

Please make sure to check the following tasks before opening and submitting a PR

I understand and have followed the contribution guide
I have tested my changes locally and they are working as intended
These changes do not have any notable side effects on other Revolt projects

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/python-client-sdk/pull/63 **Author:** [@Solarphlare](https://github.com/Solarphlare) **Created:** 7/9/2023 **Status:** ✅ Merged **Merged:** 7/19/2023 **Merged by:** [@Zomatree](https://github.com/Zomatree) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`2f63f7c`](https://github.com/stoatchat/python-client-sdk/commit/2f63f7c40f2d6f1dd47dd3cd23ea13297355ca5b) Fix parameters not being passed in remove_reaction - [`cf9634f`](https://github.com/stoatchat/python-client-sdk/commit/cf9634f0c78614a0324ecce31b05882f4f14702e) Update revolt/http.py ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `revolt/http.py` (+1 -1) </details> ### 📄 Description The parameters dict containing `user_id` and `remove_all` are never passed to the request function, so attempting to remove a specific user's reactions or all reactions of a particular emoji will not work. This PR rectifies the issue by passing the parameters dict to the request function. ## Please make sure to check the following tasks before opening and submitting a PR * [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/revolt/discussions/282) * [x] I have tested my changes locally and they are working as intended * [x] These changes do not have any notable side effects on other Revolt projects --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 23:16:35 -05:00

yindo closed this issue

2026-02-15 23:16:35 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: stoatchat/python-client-sdk#83