[PR #74] [CLOSED] fix: Server.create_role raising a KeyError #87

Closed
opened 2026-02-15 23:16:36 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/stoatchat/python-client-sdk/pull/74
Author: @andrewthederp
Created: 4/10/2024
Status: Closed

Base: masterHead: master


📝 Commits (2)

  • ea55ce1 Fix KeyError when using Server.create_role
  • add5b6d Add some typehints

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 revolt/server.py (+5 -2)

📄 Description

Server.state.http.create_role returns a payload in a format different from what Role expects. This pr extracts the needed information from Server.state.http.create_role to feed into Role

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/python-client-sdk/pull/74 **Author:** [@andrewthederp](https://github.com/andrewthederp) **Created:** 4/10/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ea55ce1`](https://github.com/stoatchat/python-client-sdk/commit/ea55ce1a6c85d8b5f6822940a73774c2e89680f7) Fix KeyError when using `Server.create_role` - [`add5b6d`](https://github.com/stoatchat/python-client-sdk/commit/add5b6d1ba64223ef6f33baab7e15c7ef776582a) Add some typehints ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `revolt/server.py` (+5 -2) </details> ### 📄 Description `Server.state.http.create_role` returns a payload in a format different from what `Role` expects. This pr extracts the needed information from `Server.state.http.create_role` to feed into `Role` ## Please make sure to check the following tasks before opening and submitting a PR - [x] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [x] I have tested my changes locally and they are working as intended --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 23:16:36 -05:00
yindo closed this issue 2026-02-15 23:16:36 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/python-client-sdk#87