From 91becd9e4fa2db089ddc6b21dadc06133e939e08 Mon Sep 17 00:00:00 2001 From: Tony <68118705+Legend-Master@users.noreply.github.com> Date: Mon, 8 Dec 2025 20:13:52 +0800 Subject: [PATCH] fix(nsis): plugins not signed (#14627) --- .changes/nsis-plugin-sign-path.md | 5 +++++ .../src/bundle/windows/nsis/mod.rs | 17 ++++++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) create mode 100644 .changes/nsis-plugin-sign-path.md diff --git a/.changes/nsis-plugin-sign-path.md b/.changes/nsis-plugin-sign-path.md new file mode 100644 index 000000000..99f4f6861 --- /dev/null +++ b/.changes/nsis-plugin-sign-path.md @@ -0,0 +1,5 @@ +--- +tauri-bundler: patch:bug +--- + +Fix NSIS plugins not being signed due to wrong path handlings diff --git a/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs b/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs index f456ed97a..d4d8f2cac 100644 --- a/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs +++ b/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs @@ -621,13 +621,16 @@ fn build_nsis_app_installer( fs::create_dir_all(nsis_installer_path.parent().unwrap())?; if settings.windows().can_sign() { - log::info!("Signing NSIS plugins"); - for dll in NSIS_PLUGIN_FILES { - let path = additional_plugins_path.join(dll); - if path.exists() { - try_sign(&path, settings)?; - } else { - log::warn!("Could not find {}, skipping signing", path.display()); + if let Some(plugin_copy_path) = &maybe_plugin_copy_path { + let plugin_copy_path = plugin_copy_path.join("x86-unicode"); + log::info!("Signing NSIS plugins"); + for dll in NSIS_PLUGIN_FILES { + let path = plugin_copy_path.join(dll); + if path.exists() { + try_sign(&path, settings)?; + } else { + log::warn!("Could not find {}, skipping signing", path.display()); + } } } }