From 91cb5c0c7ff63e23e91b554d03d51f1f325468d0 Mon Sep 17 00:00:00 2001 From: Lucas Fernandes Nogueira Date: Wed, 6 Jul 2022 11:03:56 -0300 Subject: [PATCH] fix(windows): generate 32x32 ico files (#75) --- .changes/fix-ico.md | 5 +++++ src/tauricon.ts | 11 ++--------- 2 files changed, 7 insertions(+), 9 deletions(-) create mode 100644 .changes/fix-ico.md diff --git a/.changes/fix-ico.md b/.changes/fix-ico.md new file mode 100644 index 0000000..e2b8fcc --- /dev/null +++ b/.changes/fix-ico.md @@ -0,0 +1,5 @@ +--- +"tauricon": patch +--- + +Generate 32x32 ICO icons for better compatibility with the window icon on Windows. diff --git a/src/tauricon.ts b/src/tauricon.ts index d8600fe..53bc966 100644 --- a/src/tauricon.ts +++ b/src/tauricon.ts @@ -509,14 +509,7 @@ const tauricon = { await this.validate(src, target) const s = sharp(src) - const metadata = await s.metadata() - let icoBuf - if (metadata.width !== metadata.height) { - const size = Math.min(metadata.width ?? 256, metadata.height ?? 256) - icoBuf = await s.resize(size, size).toBuffer() - } else { - icoBuf = await s.toBuffer() - } + const icoBuf = await s.resize(32, 32).toBuffer() const icns = new Icns() for (const key in icnsImageList) { @@ -532,7 +525,7 @@ const tauricon = { ensureFileSync(path.join(target, '/icon.icns')) writeFileSync(path.join(target, '/icon.icns'), icns.data) - const out2 = await pngToIco(icoBuf) + const out2 = await pngToIco([icoBuf]) if (out2 === null) { throw new Error('Failed to create icon.ico') }