topjohnwu/libsu
1
0
Fork 0
mirror of https://github.com/topjohnwu/libsu.git synced 2024-10-07 09:13:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve SuFile implementation

Browse Source
This commit is contained in:
topjohnwu 2018-02-21 21:53:46 +08:00
parent f44d98cbc3
commit 743133f3e0
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
superuser/src/main/java/com/topjohnwu/superuser/io/SuFile.java
View File

@ -68,22 +68,22 @@ public class SuFile extends File {
public SuFile(@NonNull String pathname) {
super(pathname);
checkShell();
checkIfUseShell();
}
public SuFile(String parent, @NonNull String child) {
super(parent, child);
checkShell();
checkIfUseShell();
}
public SuFile(File parent, @NonNull String child) {
super(parent, child);
checkShell();
checkIfUseShell();
}
public SuFile(@NonNull URI uri) {
super(uri);
checkShell();
checkIfUseShell();
}
/**
@ -92,7 +92,7 @@ public class SuFile extends File {
*/
public SuFile(@NonNull File file) {
super(file.getAbsolutePath());
checkShell();
checkIfUseShell();
}
/**
@ -111,19 +111,22 @@ public class SuFile extends File {
*/
public SuFile(@NonNull String pathname, boolean shell) {
super(pathname);
useShell = shell;
if (useShell)
absolutePath = super.getAbsolutePath();
useShell = shell && Shell.rootAccess();
testShell();
}
boolean useShell() {
return useShell;
}
private void checkShell() {
private void checkIfUseShell() {
// We at least need to be able to write to parent, and rw if exists
useShell = (!super.getParentFile().canWrite() ||
super.exists() && (!super.canRead() || !super.canWrite())) && Shell.rootAccess();
testShell();
}
private void testShell() {
if (useShell) {
// The absolutePath will not change if using shell
absolutePath = super.getAbsolutePath();