topjohnwu/ndk-busybox
1
0
Fork 0
mirror of https://github.com/topjohnwu/ndk-busybox.git synced 2024-11-23 11:49:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

- add note about removing superfluous fmt specifiers

Browse Source
This commit is contained in:
Bernhard Reutner-Fischer 2006-06-04 16:05:02 +00:00
parent 395010b1f0
commit 863073da08
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
TODO
View File

@ -259,12 +259,17 @@ Minor stuff:
if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2);
Unfortunately, that needs linux/watchdog.h and that contains unfiltered Unfortunately, that needs linux/watchdog.h and that contains unfiltered
kernel types on some distros, which breaks the build. kernel types on some distros, which breaks the build.
---
use bb_error_msg where appropriate: See use bb_error_msg where appropriate: See
egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))"
---
use bb_perror_msg where appropriate: See use bb_perror_msg where appropriate: See
egrep "[^_]perror" egrep "[^_]perror"
---
Remove superfluous fmt occurances: e.g.
fprintf(stderr, "%s: %s not found\n", "unalias", *argptr);
-> fprintf(stderr, "unalias: %s not found\n", *argptr);
---
Code cleanup: Code cleanup: