From 1b36ace21bb1177ae97f5249231a176541e859a8 Mon Sep 17 00:00:00 2001 From: Nicolas Iooss Date: Sun, 31 Jan 2021 21:57:13 +0100 Subject: [PATCH] libsepol: include header files in source files when matching declarations It is good practise in C to include the header file that specifies the prototype of functions which are defined in the source file. Otherwise, the function prototypes which be different, which could cause unexpected issues. Add the include directives to do this. Signed-off-by: Nicolas Iooss --- libsepol/cil/src/cil_find.c | 1 + libsepol/cil/src/cil_fqn.c | 1 + libsepol/cil/src/cil_mem.c | 1 + libsepol/cil/src/cil_parser.c | 1 + libsepol/cil/src/cil_policy.c | 1 + libsepol/cil/src/cil_reset_ast.c | 1 + libsepol/src/kernel_to_cil.c | 1 + libsepol/src/kernel_to_conf.c | 1 + libsepol/src/services.c | 1 + 9 files changed, 9 insertions(+) diff --git a/libsepol/cil/src/cil_find.c b/libsepol/cil/src/cil_find.c index 638b675d..3898725f 100644 --- a/libsepol/cil/src/cil_find.c +++ b/libsepol/cil/src/cil_find.c @@ -30,6 +30,7 @@ #include #include "cil_internal.h" +#include "cil_find.h" #include "cil_flavor.h" #include "cil_list.h" #include "cil_log.h" diff --git a/libsepol/cil/src/cil_fqn.c b/libsepol/cil/src/cil_fqn.c index 2e76f873..097222a8 100644 --- a/libsepol/cil/src/cil_fqn.c +++ b/libsepol/cil/src/cil_fqn.c @@ -31,6 +31,7 @@ #include #include +#include "cil_fqn.h" #include "cil_internal.h" #include "cil_log.h" #include "cil_strpool.h" diff --git a/libsepol/cil/src/cil_mem.c b/libsepol/cil/src/cil_mem.c index f73021b5..8e4a1d24 100644 --- a/libsepol/cil/src/cil_mem.c +++ b/libsepol/cil/src/cil_mem.c @@ -33,6 +33,7 @@ #include #include "cil_log.h" +#include "cil_mem.h" void *cil_malloc(size_t size) { diff --git a/libsepol/cil/src/cil_parser.c b/libsepol/cil/src/cil_parser.c index b62043b9..0038eed6 100644 --- a/libsepol/cil/src/cil_parser.c +++ b/libsepol/cil/src/cil_parser.c @@ -38,6 +38,7 @@ #include "cil_mem.h" #include "cil_tree.h" #include "cil_lexer.h" +#include "cil_parser.h" #include "cil_strpool.h" #include "cil_stack.h" diff --git a/libsepol/cil/src/cil_policy.c b/libsepol/cil/src/cil_policy.c index 06d7d74e..74edb345 100644 --- a/libsepol/cil/src/cil_policy.c +++ b/libsepol/cil/src/cil_policy.c @@ -41,6 +41,7 @@ #include "cil_flavor.h" #include "cil_find.h" #include "cil_mem.h" +#include "cil_policy.h" #include "cil_tree.h" #include "cil_list.h" #include "cil_symtab.h" diff --git a/libsepol/cil/src/cil_reset_ast.c b/libsepol/cil/src/cil_reset_ast.c index 52e5f640..3da1b9a6 100644 --- a/libsepol/cil/src/cil_reset_ast.c +++ b/libsepol/cil/src/cil_reset_ast.c @@ -2,6 +2,7 @@ #include "cil_internal.h" #include "cil_log.h" #include "cil_list.h" +#include "cil_reset_ast.h" #include "cil_symtab.h" static inline void cil_reset_classperms_list(struct cil_list *cp_list); diff --git a/libsepol/src/kernel_to_cil.c b/libsepol/src/kernel_to_cil.c index c247b32f..a146ac51 100644 --- a/libsepol/src/kernel_to_cil.c +++ b/libsepol/src/kernel_to_cil.c @@ -16,6 +16,7 @@ #define IPPROTO_SCTP 132 #endif +#include #include #include #include diff --git a/libsepol/src/kernel_to_conf.c b/libsepol/src/kernel_to_conf.c index 62bf706c..a22f196d 100644 --- a/libsepol/src/kernel_to_conf.c +++ b/libsepol/src/kernel_to_conf.c @@ -15,6 +15,7 @@ #define IPPROTO_SCTP 132 #endif +#include #include #include #include diff --git a/libsepol/src/services.c b/libsepol/src/services.c index 72b39657..6596431c 100644 --- a/libsepol/src/services.c +++ b/libsepol/src/services.c @@ -59,6 +59,7 @@ #include #include #include +#include #include "debug.h" #include "private.h"