topjohnwu/selinux
1
0
Fork 0
mirror of https://github.com/topjohnwu/selinux.git synced 2024-11-28 05:50:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

open_init_pty: Do not make stdin and stdout non-blocking

Browse Source 
It is unclear why this was being done in the first place, and
it has caused multiple bugs with run_init/open_init_pty usage.

Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863187
Fixes: https://bugs.gentoo.org/show_bug.cgi?id=621062
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
This commit is contained in:
Stephen Smalley 2017-07-10 13:03:01 -04:00
parent 83fbc0979d
commit fb081eb64b
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
policycoreutils/run_init/open_init_pty.c
View File

@ -276,10 +276,8 @@ int main(int argc, char *argv[])
} }
} }
/* Non blocking mode for all file descriptors. */ /* Non blocking mode for the pty master. */
setfd_nonblock(pty_master); setfd_nonblock(pty_master);
setfd_nonblock(STDIN_FILENO);
setfd_nonblock(STDOUT_FILENO);
if (isatty(STDIN_FILENO)) { if (isatty(STDIN_FILENO)) {
if (tty_semi_raw(STDIN_FILENO) < 0) { if (tty_semi_raw(STDIN_FILENO) < 0) {