It makes more sense to print it as a warning, because it's not a hard
error for now (until we resolve all violations and create a compliance
test)
Bug: N/A
Test: boot
Change-Id: Iac5deb1f965394ecd4c2acb3711bd07317956236
am skip reason: Merged-In I2dd51a995d76b2c50dae2b2c4af8e3a3a4599408 with SHA-1 321c025259 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/selinux/+/2672475
Change-Id: Ic05b9fd952bc73c2ef09efc0caf44176e8fe4070
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I6ed125eff392020ace6686514e0a102dab1fb10f with SHA-1 dc9f3516d7 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/selinux/+/2670896
Change-Id: I56fde84cc24aa611530d254910a0ecc4f02c3681
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This is to remove duplicate errors while fixing seapp_contexts
violations (because old vendors still have the entries).
Bug: 280547417
Test: TH
Change-Id: I8c381dad6e8bf5e91148494b55278e124b845c13
There is a bug on the code checking the partition, so it's printing
wrong logcat messages. This fixes it by renaming the function name for
better readability.
Also it fixes a bug that the check only happens when levelFrom != NONE.
Bug: 291005833
Test: boot and see logcat
Merged-In: I2dd51a995d76b2c50dae2b2c4af8e3a3a4599408
Change-Id: I2dd51a995d76b2c50dae2b2c4af8e3a3a4599408
(cherry picked from commit 321c0252599f525833bea20d9b3b7e3f1d0edee1)
There is a bug on the code checking the partition, so it's printing
wrong logcat messages. This fixes it by renaming the function name for
better readability.
Also it fixes a bug that the check only happens when levelFrom != NONE.
Bug: 291005833
Test: boot and see logcat
Change-Id: I2dd51a995d76b2c50dae2b2c4af8e3a3a4599408
There are two problems addressed by this change.
1) qsort doesn't compare all pairs of elements having the same
precedence. We can't rely only on qsort's comparator to detect
duplicates.
2) comparing logic is broken. For example,
s1->isPrivAppSet && s1->isPrivApp == s2->isPrivApp
really should be
!s1->isPrivAppSet || s1->isPrivApp == s2->isPrivApp
Bug: 291528964
Test: manually create two duplicated entries and boot
Change-Id: Ieae4a7f5419e18636bb2fd5f70700faa4fa8acf1
Right now selinux_android_restorecon will silently succeed if selinux is
disabled which is confusing.
This change adds a log statement that should help with debugging issues
related to disabled selinux (see attached bug).
Bug: 284277137
Test: presubmit
Change-Id: I4ebc6400ac7188660658ef3cccfb7cbdc76c0f22
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 8c40c00f3d is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: I03a9858ea3a9a0e7603161f02e7f2ea07a207eed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 e1c842285b is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: I0943543aad23ae411b6ed791882de4bb275eb84f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 e1c842285b is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: Ie5085774e3349de7233900a027116e7efda74d42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 8c40c00f3d is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: I32559987d9970726859168e6c18f70f5ec9d24de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 e1c842285b is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: I4fa7f87a95c0a2a05d6979e5aba52f9989b290c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 e1c842285b is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: I5b1c5f62b0f8273423dce851f3997db4fd2c0f7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I175229d135d99516dd6f38b8963d0ccc93a61a4f with SHA-1 e1c842285b is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/selinux/+/23149989
Change-Id: If267af1dfb59a6f93d8827d0edc60ab9f42fe3cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
