torproject/stem
1
0
Fork 0
mirror of https://github.com/torproject/stem.git synced 2024-12-02 15:26:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Differentiate bytes/unicode in hashes

Browse Source 
Huh. To avoid bulk refactoring our tests we included a small hack that hashed
byte and unicode types to the same value. Said another way, a unicde and byte
string for "hello" would be equal.

I expected that dropping this hack would be invasive but our tests pass. Kinda
confused, but... neat?
This commit is contained in:
Damian Johnson 2020-01-05 12:54:42 -08:00
parent aa6aaa2e6f
commit 2006edc5ee
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
stem/util/__init__.py
View File

@ -49,19 +49,10 @@ def _hash_value(val):
if not HASH_TYPES:
my_hash = 0
else:
# TODO: I hate doing this but until Python 2.x support is dropped we
# can't readily be strict about bytes vs unicode for attributes. This
# is because test assertions often use strings, and normalizing this
# would require wrapping most with to_unicode() calls.
#
# This hack will go away when we drop Python 2.x support.
# Hashing common builtins (ints, bools, etc) provide consistant values but
# many others vary their value on interpreter invokation.
if isinstance(val, (bytes, str)):
my_hash = hash('str')
else:
# Hashing common builtins (ints, bools, etc) provide consistant values but many others vary their value on interpreter invokation.
my_hash = hash(str(type(val)))
my_hash = hash(str(type(val)))
if isinstance(val, (tuple, list)):
for v in val: