torproject/torbrowser-launcher
1
0
Fork 0
mirror of https://github.com/torproject/torbrowser-launcher.git synced 2024-11-26 19:10:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

AppArmor: remove duplicate rule

Browse Source 
We include the gnome abstraction, which itself includes the X abstraction, so
at least in theory including the X abstraction explicitly should be a no-op.

It looks like adding this line was done based on an incorrect assumption (that
Lubuntu does not include the gnome abstraction), and even if that assumption
were correct, adding this line would not fix the problem (because the parser
would fail to compile the profile regardless).

 - https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_requests/16#note_3001282
 - https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_requests/16#note_3001283

If there's ever evidence of a system where this line actually solves a problem,
we can reconsider, and I'll be very curious to understand why.
This commit is contained in:
intrigeri 2024-10-15 11:17:37 +00:00
parent 851ff3304f
commit 9f55ecec10
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apparmor/torbrowser.Browser.firefox
View File

@ -12,7 +12,6 @@ profile torbrowser_firefox @{torbrowser_firefox_executable} {
#include <abstractions/opencl>
#include if exists <abstractions/vulkan>
#include if exists <abstractions/dbus-session>
#include if exists <abstractions/X>
deny capability sys_ptrace,