From 9f55ecec1034af865768773401d91f126dee4c7f Mon Sep 17 00:00:00 2001 From: intrigeri Date: Tue, 15 Oct 2024 11:17:37 +0000 Subject: [PATCH] AppArmor: remove duplicate rule We include the gnome abstraction, which itself includes the X abstraction, so at least in theory including the X abstraction explicitly should be a no-op. It looks like adding this line was done based on an incorrect assumption (that Lubuntu does not include the gnome abstraction), and even if that assumption were correct, adding this line would not fix the problem (because the parser would fail to compile the profile regardless). - https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_requests/16#note_3001282 - https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_requests/16#note_3001283 If there's ever evidence of a system where this line actually solves a problem, we can reconsider, and I'll be very curious to understand why. --- apparmor/torbrowser.Browser.firefox | 1 - 1 file changed, 1 deletion(-) diff --git a/apparmor/torbrowser.Browser.firefox b/apparmor/torbrowser.Browser.firefox index 6542f0e..d9a0e63 100644 --- a/apparmor/torbrowser.Browser.firefox +++ b/apparmor/torbrowser.Browser.firefox @@ -12,7 +12,6 @@ profile torbrowser_firefox @{torbrowser_firefox_executable} { #include #include if exists #include if exists - #include if exists deny capability sys_ptrace,