mirror of
https://github.com/utmapp/UTM.git
synced 2026-10-12 02:24:01 +00:00
Now that the deployment targets are iOS 15 and macOS 12, every guard, fallback and workaround for an older release is dead code that only obscures what the supported path is. Remove them: - Drop the `@available` attributes for iOS 15, macOS 11 and macOS 12, and unwrap the matching `#available`/`#unavailable` guards in Swift and the `@available`/`API_AVAILABLE`/`NS_AVAILABLE_IOS` ones in Objective-C. - Delete the legacy-only views and helpers left unreachable by that: NumberTextFieldOld, VMConfigNetworkPortForwardLegacyView, VMContextMenuModifier.bodyBigSur, the nonbrokenSheet, uniqued, customBadge, borderedList and legacySettingsToolbar shims, the .unsupported BootloaderSelection case, and the iOS 14 sacrificial version Section in the QEMU settings list. - jb_has_cs_execseg_allow_unsigned() has returned false for every host since iOS 14.4, so drop it along with the is_device_A12_or_newer() helper that only it used. The entitlement parser no longer needs to copy the blob either, since that copy existed only so the psychic paper needle could be blanked in place. - VMDisplayTerminalViewController tracked the keyboard frame by hand for iOS 14. `useAutoLayout` is a constant that cannot be overridden, so nothing ever registered the notification observers and only the keyboardLayoutGuide path is reachable. - VMConfigQEMUView's additionalArguments is now referenced on iOS only, which leaves its macOS branch, and the macOS 11 ForEach crash workaround inside it, unreachable. - Raise the Cydia package floor and the postinst/prerm helpers to match the new minimum. Two of the removed guards dropped an error path rather than just a branch. The shared directory `featureNotSupported` throw covered VZVirtioFileSystemDeviceConfiguration and friends being macOS 12+, which no longer applies to any supported host. The macOS guest `platformUnsupported` throw when decoding a boot config on Intel only fired on macOS 11; the Apple Silicon requirement it really guards is enforced unconditionally in UTMAppleConfigurationSystem.fillVZConfiguration, which both the start and the save path go through. Assisted-by: Claude:claude-opus-5
175 lines
5.2 KiB
Swift
175 lines
5.2 KiB
Swift
//
|
|
// Copyright © 2020 osy. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
import SwiftUI
|
|
|
|
struct VMSettingsView<Config: UTMConfiguration>: View {
|
|
let vm: VMData
|
|
@ObservedObject var config: Config
|
|
|
|
@EnvironmentObject private var data: UTMData
|
|
@Environment(\.presentationMode) private var presentationMode: Binding<PresentationMode>
|
|
|
|
var body: some View {
|
|
NavigationView {
|
|
List {
|
|
if config is UTMQemuConfiguration {
|
|
VMQEMUSettingsView(config: config as! UTMQemuConfiguration)
|
|
} else if config is UTMAppleConfiguration {
|
|
VMAppleSettingsView(config: config as! UTMAppleConfiguration)
|
|
}
|
|
}.listStyle(.sidebar)
|
|
Text("")
|
|
.settingsToolbar()
|
|
}
|
|
.frame(minWidth: 800, minHeight: 400, alignment: .leading)
|
|
.environmentObject(vm)
|
|
.disabled(data.busy)
|
|
.overlay(BusyOverlay())
|
|
}
|
|
|
|
func save() {
|
|
data.busyWorkAsync {
|
|
try await data.save(vm: vm)
|
|
await MainActor.run {
|
|
presentationMode.wrappedValue.dismiss()
|
|
}
|
|
}
|
|
}
|
|
|
|
func cancel() {
|
|
presentationMode.wrappedValue.dismiss()
|
|
data.busyWorkAsync {
|
|
try await data.discardChanges(for: vm)
|
|
}
|
|
}
|
|
}
|
|
|
|
struct ScrollableViewModifier: ViewModifier {
|
|
@State private var scrollViewContentSize: CGSize = .zero
|
|
|
|
func body(content: Content) -> some View {
|
|
ScrollView {
|
|
content
|
|
.frame(maxWidth: .infinity)
|
|
.padding()
|
|
.background(
|
|
GeometryReader { geo -> Color in
|
|
DispatchQueue.main.async {
|
|
scrollViewContentSize = geo.size
|
|
}
|
|
return Color.clear
|
|
}
|
|
)
|
|
}
|
|
.frame(idealWidth: scrollViewContentSize.width)
|
|
}
|
|
}
|
|
|
|
fileprivate struct EmptyToolbarContent: ToolbarContent {
|
|
var body: some ToolbarContent {
|
|
ToolbarItem {
|
|
EmptyView()
|
|
}
|
|
}
|
|
}
|
|
|
|
struct SettingsToolbarViewModifier<AdditionalContent>: ViewModifier where AdditionalContent: ToolbarContent {
|
|
@EnvironmentObject private var vm: VMData
|
|
@EnvironmentObject private var data: UTMData
|
|
@Environment(\.dismiss) private var dismiss
|
|
|
|
let additionalContent: AdditionalContent?
|
|
|
|
fileprivate init() where AdditionalContent == EmptyToolbarContent {
|
|
self.additionalContent = nil
|
|
}
|
|
|
|
init(additionalContent: () -> AdditionalContent) {
|
|
self.additionalContent = additionalContent()
|
|
}
|
|
|
|
func body(content: Content) -> some View {
|
|
let view = content.toolbar {
|
|
ToolbarItemGroup(placement: .cancellationAction) {
|
|
Button(action: cancel) {
|
|
Text("Cancel")
|
|
}
|
|
}
|
|
ToolbarItemGroup(placement: .confirmationAction) {
|
|
Form {
|
|
Button(action: save) {
|
|
Text("Save")
|
|
}
|
|
.buttonStyle(.borderedProminent)
|
|
}
|
|
}
|
|
}
|
|
if let additionalContent = additionalContent {
|
|
view.toolbar {
|
|
additionalContent
|
|
}
|
|
} else {
|
|
view
|
|
}
|
|
}
|
|
|
|
private func save() {
|
|
data.busyWorkAsync {
|
|
try await data.save(vm: vm)
|
|
await MainActor.run {
|
|
dismiss()
|
|
}
|
|
}
|
|
}
|
|
|
|
private func cancel() {
|
|
dismiss()
|
|
data.busyWorkAsync {
|
|
try await data.discardChanges(for: vm)
|
|
}
|
|
}
|
|
}
|
|
|
|
extension View {
|
|
func scrollable() -> some View {
|
|
self.modifier(ScrollableViewModifier())
|
|
}
|
|
|
|
func settingsToolbar() -> some View {
|
|
self.modifier(SettingsToolbarViewModifier())
|
|
}
|
|
|
|
func settingsToolbar<Content>(@ToolbarContentBuilder additionalContent: () -> Content) -> some View where Content: ToolbarContent {
|
|
self.modifier(SettingsToolbarViewModifier(additionalContent: additionalContent))
|
|
}
|
|
}
|
|
|
|
struct VMSettingsView_Previews: PreviewProvider {
|
|
@State static private var qemuConfig = UTMQemuConfiguration()
|
|
@State static private var appleConfig = UTMAppleConfiguration()
|
|
@State static private var data = UTMData()
|
|
|
|
static var previews: some View {
|
|
VMSettingsView(vm: VMData(from: .empty), config: qemuConfig)
|
|
.environmentObject(data)
|
|
.previewDisplayName("QEMU VM Settings")
|
|
VMSettingsView(vm: VMData(from: .empty), config: appleConfig)
|
|
.environmentObject(data)
|
|
.previewDisplayName("Apple VM Settings")
|
|
}
|
|
}
|