From a051ec217f894dada12c675f6ee3e53e7a24f7b1 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Steenis Date: Wed, 22 Nov 2017 17:57:28 +0100 Subject: [PATCH] Skip Route 53 proprietary rrsets --- providers/route53/route53.go | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/providers/route53/route53.go b/providers/route53/route53.go index e292950..5e82c7d 100644 --- a/providers/route53/route53.go +++ b/providers/route53/route53.go @@ -207,11 +207,12 @@ func (r *Route53Provider) GetRecords() ([]utils.DnsRecord, error) { } for _, rrSet := range rrSets { - // skip proprietary Route 53 alias resource record sets - if rrSet.AliasTarget != nil { - logrus.Debug("Skipped Route53 alias RRset") + // skip proprietary Route 53 resource record sets + if IsProprietary(rrSet) { + logrus.Debugf("skipped properietary rrSet: %s", rrSet) continue } + records := []string{} for _, rr := range rrSet.ResourceRecords { value := *rr.Value @@ -221,6 +222,9 @@ func (r *Route53Provider) GetRecords() ([]utils.DnsRecord, error) { records = append(records, value) } + logrus.Debugf("rrSet: %s", rrSet) + logrus.Debugf("records: %s", records) + dnsRecord := utils.DnsRecord{ Fqdn: *rrSet.Name, Records: records, @@ -232,3 +236,7 @@ func (r *Route53Provider) GetRecords() ([]utils.DnsRecord, error) { return dnsRecords, nil } + +func IsProprietary(rr *awsRoute53.ResourceRecordSet) bool { + return (rr.AliasTarget != nil || rr.TrafficPolicyInstanceId != nil) +}