vxcontrol/pentagi
1
0
Fork 0
mirror of https://github.com/vxcontrol/pentagi.git synced 2026-07-20 12:37:04 -04:00
Code Issues 45 Packages Projects Releases 9 Wiki Activity

[PR #22] [MERGED] Update entrypoint in docker-compose for Langfuse MinIO #123

New Issue
Closed
opened 2026-06-06 22:09:17 -04:00 by yindo · 0 comments
yindo commented 2026-06-06 22:09:17 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/pentagi/pull/22
Author: @asdek
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @asdek

Base: master ← Head: 9-bug-invalid-interpolation-format-for-minio-entrypoint

📝 Commits (1)

  • 0eb8d2c fix: update entrypoint script in docker-compose for Langfuse MinIO configuration

📊 Changes

1 file changed (+7 additions, -7 deletions)

View changed files

📝 docker-compose-langfuse.yml (+7 -7)

📄 Description

Description of the Change

Problem

The MinIO service configuration in docker-compose-langfuse.yml had issues with environment variable interpolation and command execution in the entrypoint script. The original configuration used incorrect syntax for shell variables and command substitution, which caused Docker Compose to fail during startup.

Solution

The changes include:

  1. Changed the entrypoint syntax from > to | to properly handle multiline shell scripts
  2. Fixed environment variable references by using proper shell variable syntax
  3. Corrected command substitution syntax for process management
  4. Improved code formatting and comments for better maintainability

Closes #9

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Configuration change
  • 🧪 Test update
  • 🛡️ Security update

Areas Affected

  • Core Services (Frontend UI/Backend API)
  • AI Agents (Researcher/Developer/Executor)
  • Security Tools Integration
  • Memory System (Vector Store/Knowledge Base)
  • Monitoring Stack (Grafana/OpenTelemetry)
  • Analytics Platform (Langfuse)
  • External Integrations (LLM/Search APIs)
  • Documentation
  • Infrastructure/DevOps

Testing and Verification

Test Configuration

PentAGI Version: latest
Docker Version: 28.0.1
Host OS: darwin 24.3.0
LLM Provider: N/A
Enabled Features: [Langfuse]

Test Steps

  1. Stop any running Langfuse containers
  2. Apply the changes to docker-compose-langfuse.yml
  3. Start the services using docker-compose -f docker-compose-langfuse.yml up -d
  4. Verify MinIO service starts successfully
  5. Check MinIO bucket creation and configuration

Test Results

The MinIO service now starts correctly with proper environment variable interpolation and command execution. The bucket is created and configured as expected.

Security Considerations

No security implications as this is a configuration fix that maintains existing security settings.

Performance Impact

No performance impact as this is a configuration fix that improves reliability.

Documentation Updates

  • README.md updates
  • API documentation updates
  • Configuration documentation updates
  • GraphQL schema updates
  • Other:

Deployment Notes

No special deployment considerations. The changes are backward compatible and maintain existing environment variable structure.

Checklist

Code Quality

  • My code follows the project's coding standards
  • I have added/updated necessary documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have run go fmt and go vet (for Go code)
  • I have run npm run lint (for TypeScript/JavaScript code)

Security

  • I have considered security implications
  • Changes maintain or improve the security model
  • Sensitive information has been properly handled

Compatibility

  • Changes are backward compatible
  • Breaking changes are clearly marked and documented
  • Dependencies are properly updated

Documentation

  • Documentation is clear and complete
  • Comments are added for non-obvious code
  • API changes are documented

Additional Notes

The changes are focused on fixing the MinIO service configuration in the Langfuse stack. The modifications improve reliability and maintainability without affecting the core functionality or security of the system.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/pentagi/pull/22 **Author:** [@asdek](https://github.com/asdek) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `master` ← **Head:** `9-bug-invalid-interpolation-format-for-minio-entrypoint` --- ### 📝 Commits (1) - [`0eb8d2c`](https://github.com/vxcontrol/pentagi/commit/0eb8d2ce6e93ed424f58a6a97bbce8b1bc56fd4c) fix: update entrypoint script in docker-compose for Langfuse MinIO configuration ### 📊 Changes **1 file changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose-langfuse.yml` (+7 -7) </details> ### 📄 Description <!-- Thank you for your contribution to PentAGI! Please fill out this template completely to help us review your changes effectively. Any PR that does not include enough information may be closed at maintainers' discretion. --> ### Description of the Change <!-- We must be able to understand the design of your change from this description. Please provide as much detail as possible. --> #### Problem The MinIO service configuration in docker-compose-langfuse.yml had issues with environment variable interpolation and command execution in the entrypoint script. The original configuration used incorrect syntax for shell variables and command substitution, which caused Docker Compose to fail during startup. #### Solution The changes include: 1. Changed the entrypoint syntax from `>` to `|` to properly handle multiline shell scripts 2. Fixed environment variable references by using proper shell variable syntax 3. Corrected command substitution syntax for process management 4. Improved code formatting and comments for better maintainability <!-- Enter any applicable Issue number(s) here that will be closed/resolved by this PR. --> Closes #9 ### Type of Change <!-- Mark with an `x` all options that apply --> - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] 🚀 New feature (non-breaking change which adds functionality) - [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 📚 Documentation update - [x] 🔧 Configuration change - [ ] 🧪 Test update - [ ] 🛡️ Security update ### Areas Affected <!-- Mark with an `x` all components that are affected --> - [ ] Core Services (Frontend UI/Backend API) - [ ] AI Agents (Researcher/Developer/Executor) - [ ] Security Tools Integration - [ ] Memory System (Vector Store/Knowledge Base) - [ ] Monitoring Stack (Grafana/OpenTelemetry) - [x] Analytics Platform (Langfuse) - [ ] External Integrations (LLM/Search APIs) - [ ] Documentation - [x] Infrastructure/DevOps ### Testing and Verification <!-- Please describe the tests that you ran to verify your changes and provide instructions so we can reproduce. --> #### Test Configuration ```yaml PentAGI Version: latest Docker Version: 28.0.1 Host OS: darwin 24.3.0 LLM Provider: N/A Enabled Features: [Langfuse] ``` #### Test Steps 1. Stop any running Langfuse containers 2. Apply the changes to docker-compose-langfuse.yml 3. Start the services using `docker-compose -f docker-compose-langfuse.yml up -d` 4. Verify MinIO service starts successfully 5. Check MinIO bucket creation and configuration #### Test Results The MinIO service now starts correctly with proper environment variable interpolation and command execution. The bucket is created and configured as expected. ### Security Considerations <!-- Describe any security implications of your changes. For security-related changes, please note any new dependencies, changed permissions, etc. --> No security implications as this is a configuration fix that maintains existing security settings. ### Performance Impact <!-- Describe any performance implications and testing done to verify acceptable performance. Especially important for changes affecting AI agents, memory systems, or data processing. --> No performance impact as this is a configuration fix that improves reliability. ### Documentation Updates <!-- Note any documentation changes required by this PR --> - [ ] README.md updates - [ ] API documentation updates - [ ] Configuration documentation updates - [ ] GraphQL schema updates - [ ] Other: <!-- specify --> ### Deployment Notes <!-- Describe any special considerations for deploying this change. Include any new environment variables, configuration changes, or migration steps. --> No special deployment considerations. The changes are backward compatible and maintain existing environment variable structure. ### Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> #### Code Quality - [x] My code follows the project's coding standards - [x] I have added/updated necessary documentation - [ ] I have added tests to cover my changes - [x] All new and existing tests pass - [ ] I have run `go fmt` and `go vet` (for Go code) - [ ] I have run `npm run lint` (for TypeScript/JavaScript code) #### Security - [x] I have considered security implications - [x] Changes maintain or improve the security model - [x] Sensitive information has been properly handled #### Compatibility - [x] Changes are backward compatible - [x] Breaking changes are clearly marked and documented - [x] Dependencies are properly updated #### Documentation - [x] Documentation is clear and complete - [x] Comments are added for non-obvious code - [ ] API changes are documented ### Additional Notes <!-- Any additional information that would be helpful for reviewers --> The changes are focused on fixing the MinIO service configuration in the Langfuse stack. The modifications improve reliability and maintainability without affecting the core functionality or security of the system. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-06 22:09:17 -04:00
yindo closed this issue 2026-06-06 22:09:17 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vxcontrol/pentagi#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?