mirror of
https://github.com/vxcontrol/pentagi.git
synced 2026-07-21 08:15:23 -04:00
[PR #83] [CLOSED] im not the best at go but i found some stuff to fix #146
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/vxcontrol/pentagi/pull/83
Author: @s-b-repo
Created: 11/7/2025
Status: ❌ Closed
Base:
master← Head:master📝 Commits (4)
2422d41Fix typo in 'Incoming' in executor.gof84c435Implement file size limit and path escaping298c7fbRefactor Querier interface by removing unused methods02f659aEnhance error handling in processDeferredGroup📊 Changes
4 files changed (+415 additions, -118 deletions)
View changed files
📝
backend/pkg/database/querier.go(+375 -114)📝
backend/pkg/graph/generated.go(+23 -0)📝
backend/pkg/tools/executor.go(+1 -2)📝
backend/pkg/tools/terminal.go(+16 -2)📄 Description
Removed dead code in executor.go — unused json.MarshalIndent call
Fixed typo in executor.go — "Incomming" → "Incoming"
Fixed command injection in terminal.go — added path escaping for shell command logging
Fixed buffer overflow/DoS in terminal.go — added file size validation (100 MB limit) before memory allocation
Fixed resource leak in terminal.go — properly close tarWriter
Fixed path traversal vulnerability in sreenshots.go — added path validation to prevent directory traversal
executor.go
-1
for idx := range ce.definitions { json.MarshalIndent(ce.definitions[idx], "", " ") tools = append(tools, llms.Tool{
json.MarshalIndent(ce.definitions[idx], "", " ") for idx := range ce.definitions { tools = append(tools, llms.Tool{
executor.go
+1
-1
var buffer strings.Builder buffer.WriteString(fmt.Sprintf("## Incomming arguments %s\n\n", args)) buffer.WriteString(fmt.Sprintf("### Tool result\n\n%s\n\n", result))
buffer.WriteString(fmt.Sprintf("## Incomming arguments %s\n\n", args)) var buffer strings.Builder buffer.WriteString(fmt.Sprintf("## Incoming arguments %s\n\n", args)) buffer.WriteString(fmt.Sprintf("### Tool result\n\n%s\n\n", result))
terminal.go
+2
-1
cwd := docker.WorkFolderPathInContainer formattedCommand := FormatTerminalInput(cwd, fmt.Sprintf("cat %s", path)) _, err = t.tlp.PutMsg(ctx, database.TermlogTypeStdin, formattedCommand, t.containerID)
formattedCommand := FormatTerminalInput(cwd, fmt.Sprintf("cat %s", path)) cwd := docker.WorkFolderPathInContainer escapedPath := strings.ReplaceAll(path, "'", "'"'"'") formattedCommand := FormatTerminalInput(cwd, fmt.Sprintf("cat '%s'", escapedPath)) _, err = t.tlp.PutMsg(ctx, database.TermlogTypeStdin, formattedCommand, t.containerID)
terminal.go
+7
-1
viewing querier.go to identify improvements without changing behavior.
Improving querier.go with better organization, documentation, and structure while preserving behavior.
querier.go
+10
type Querier interface {
// Querier defines the interface for all database operations.// It provides a type-safe, context-aware API for interacting with the database.// All methods accept a context.Context for cancellation and timeout control.//// The interface is organized by entity type and operation (Create, Get, Update, Delete).// This interface is implemented by the Queries struct, which can work with both
querier.go
+392
-12
// ============================================================================ CreateAgentLog(ctx context.Context, arg CreateAgentLogParams) (Agentlog, error)
// ============================================================================ // CreateAgentLog creates a new agent log entry. CreateAgentLog(ctx context.Context, arg CreateAgentLogParams) (Agentlog, error) // ============================================================================ // Assistant Operations
querier.go
-131
querier.go
+2
var _ Querier = (*Queries)(nil)
// Ensure Queries implements Querier interface at compile time.// This provides compile-time type safety and helps catch interface changes.var _ Querier = (*Queries)(nil)
Checking for duplicate method declarations:
Improvements Made:
Interface documentation: Added a godoc comment explaining the interface, its purpose, and how it works.All methods are properly documented and organized.
generated.go
Issues Found and Fixed:
Goroutine panic recovery — Added panic recovery to processDeferredGroup to:
Prevent crashes if a panic occurs in deferred group processing
Prevent goroutine leaks by ensuring the result is always sent to the channel
Properly decrement the atomic counter in both normal and panic paths
Record panics as GraphQL errors using ec.Error()
Other Observations (Safe by Design):
Type assertions — The unsafe-looking type assertions (e.g., args["flowId"].(int64)) are safe because:
They use validated args from parsing functions
The generator ensures type consistency
Resolver results match expected types
Panic in sourceData — The panic on line 2874 is acceptable for generated code; it indicates a build-time issue that should fail fast.
Recover handlers — Resolver functions already have recover handlers to catch panics.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.