vxcontrol/pentagi
1
0
Fork 0
mirror of https://github.com/vxcontrol/pentagi.git synced 2026-07-21 08:15:23 -04:00
Code Issues 45 Packages Projects Releases 9 Wiki Activity

[PR #140] [MERGED] fix: add missing closing quote in GetUser swagger annotation #186

New Issue
Closed
opened 2026-06-06 22:09:36 -04:00 by yindo · 0 comments
yindo commented 2026-06-06 22:09:36 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/pentagi/pull/140
Author: @mason5052
Created: 2/23/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @asdek

Base: feature/project_improvements ← Head: fix/swagger-missing-quote

📝 Commits (1)

  • 545a6b1 fix: add missing closing quote in GetUser swagger annotation

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/pkg/server/services/users.go (+1 -1)

📄 Description

Description of the Change

Problem

The @Failure 403 swagger comment for GetUser is missing the closing double-quote on its description string:

// BEFORE
// @Failure 403 {object} response.errorResp "getting user not permitted

This causes malformed Swagger/OpenAPI documentation output.

Solution

Add the missing closing quote:

// AFTER
// @Failure 403 {object} response.errorResp "getting user not permitted"

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Areas Affected

  • Core Services (Frontend UI/Backend API)

Testing and Verification

Test Steps

  1. Run swag init — no longer produces a malformed annotation warning for this line
  2. Generated Swagger JSON correctly includes the 403 description string

Security Considerations

No security implications. Comment-only change.

Checklist

Code Quality

  • My code follows the project's coding standards
  • All new and existing tests pass
  • I have run go fmt and go vet (for Go code)

Security

  • I have considered security implications
  • Changes maintain or improve the security model

Compatibility

  • Changes are backward compatible

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/pentagi/pull/140 **Author:** [@mason5052](https://github.com/mason5052) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `feature/project_improvements` ← **Head:** `fix/swagger-missing-quote` --- ### 📝 Commits (1) - [`545a6b1`](https://github.com/vxcontrol/pentagi/commit/545a6b1fb99c4be79654a938d797b1d18e3fb6ef) fix: add missing closing quote in GetUser swagger annotation ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/pkg/server/services/users.go` (+1 -1) </details> ### 📄 Description ## Description of the Change ### Problem The `@Failure 403` swagger comment for `GetUser` is missing the closing double-quote on its description string: ```go // BEFORE // @Failure 403 {object} response.errorResp "getting user not permitted ``` This causes malformed Swagger/OpenAPI documentation output. ### Solution Add the missing closing quote: ```go // AFTER // @Failure 403 {object} response.errorResp "getting user not permitted" ``` ### Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [x] Documentation update ### Areas Affected - [x] Core Services (Frontend UI/Backend API) ### Testing and Verification #### Test Steps 1. Run `swag init` — no longer produces a malformed annotation warning for this line 2. Generated Swagger JSON correctly includes the 403 description string ### Security Considerations No security implications. Comment-only change. ### Checklist #### Code Quality - [x] My code follows the project's coding standards - [x] All new and existing tests pass - [x] I have run `go fmt` and `go vet` (for Go code) #### Security - [x] I have considered security implications - [x] Changes maintain or improve the security model #### Compatibility - [x] Changes are backward compatible --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-06 22:09:36 -04:00
yindo closed this issue 2026-06-06 22:09:36 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vxcontrol/pentagi#186
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?