[PR #33] [MERGED] Common module protocol implementation #34

New Issue

2026-06-06T22:10:45-04:00

yindo commented

2026-06-06 22:10:45 -04:00

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/soldr-modules/pull/33
Author: @NexoMichael
Created: 12/20/2022
Status: ✅ Merged
Merged: 12/21/2022
Merged by: @asdek

Base: master ← Head: module_protocol

📝 Commits (6)

7fc9e94 fix utils/mock
d962eb3 add common module protocol implementation
8d829e8 remove outdated module tests
c6b6df1 refactor file_remover to use new common module protocol implementation
616faaa add file_remover unit tests
701cf72 add junit test results output formatter

📊 Changes

17 files changed (+1512 additions, -785 deletions)

View changed files

📝 file_remover/1.0.0/bmodule/main.vue (+141 -125)
📝 file_remover/1.0.0/cmodule/args.json (+2 -1)
➕ file_remover/1.0.0/cmodule/file_remove_other_os.lua (+3 -0)
➕ file_remover/1.0.0/cmodule/file_remove_windows.lua (+34 -0)
📝 file_remover/1.0.0/cmodule/main.lua (+83 -177)
📝 file_remover/1.0.0/smodule/main.lua (+2 -88)
➖ tests/file_remover.lua (+0 -151)
➕ tests/file_remover_client_spec.lua (+354 -0)
➕ tests/file_remover_server_spec.lua (+215 -0)
➖ tests/file_remover_spec.lua (+0 -179)
➕ tests_framework/junit_with_utf_terminal.lua (+14 -0)
📝 utils/mock/agents.lua (+9 -9)
📝 utils/mock/core.lua (+69 -55)
➕ utils/protocol/actions_validator.lua (+64 -0)
➕ utils/protocol/cmodule.lua (+247 -0)
➕ utils/protocol/protocol.lua (+38 -0)
➕ utils/protocol/smodule.lua (+237 -0)

📄 Description

This PR adds several things:

implementation of a common module communication protocol (utils/protocol) which enables module-creators to simplify logic of the module and remove redundant copy-paste code in modules
refactoring of "file_remover" in favor of using utils/protocl as a module baseline
new unit tests for file_remover with covering both server and client parts
some file_remover minor issues fixes
fixes https://github.com/vxcontrol/soldr-modules/issues/17

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/soldr-modules/pull/33 **Author:** [@NexoMichael](https://github.com/NexoMichael) **Created:** 12/20/2022 **Status:** ✅ Merged **Merged:** 12/21/2022 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `master` ← **Head:** `module_protocol` --- ### 📝 Commits (6) - [`7fc9e94`](https://github.com/vxcontrol/soldr-modules/commit/7fc9e94903fa0a0c2ad78fc1c4b23d6681331302) fix utils/mock - [`d962eb3`](https://github.com/vxcontrol/soldr-modules/commit/d962eb358d95a2928d089ac0774a010ae2235b43) add common module protocol implementation - [`8d829e8`](https://github.com/vxcontrol/soldr-modules/commit/8d829e8c882e0ef3a6b3d440335d122e21e83929) remove outdated module tests - [`c6b6df1`](https://github.com/vxcontrol/soldr-modules/commit/c6b6df1ce6a921e8c08856061d78fd4413f8526c) refactor file_remover to use new common module protocol implementation - [`616faaa`](https://github.com/vxcontrol/soldr-modules/commit/616faaa8d54c3bb31869a43429c6f73546d838d5) add file_remover unit tests - [`701cf72`](https://github.com/vxcontrol/soldr-modules/commit/701cf72ea106ef95ec224d851a891d8b143ab384) add junit test results output formatter ### 📊 Changes **17 files changed** (+1512 additions, -785 deletions) <details> <summary>View changed files</summary> 📝 `file_remover/1.0.0/bmodule/main.vue` (+141 -125) 📝 `file_remover/1.0.0/cmodule/args.json` (+2 -1) ➕ `file_remover/1.0.0/cmodule/file_remove_other_os.lua` (+3 -0) ➕ `file_remover/1.0.0/cmodule/file_remove_windows.lua` (+34 -0) 📝 `file_remover/1.0.0/cmodule/main.lua` (+83 -177) 📝 `file_remover/1.0.0/smodule/main.lua` (+2 -88) ➖ `tests/file_remover.lua` (+0 -151) ➕ `tests/file_remover_client_spec.lua` (+354 -0) ➕ `tests/file_remover_server_spec.lua` (+215 -0) ➖ `tests/file_remover_spec.lua` (+0 -179) ➕ `tests_framework/junit_with_utf_terminal.lua` (+14 -0) 📝 `utils/mock/agents.lua` (+9 -9) 📝 `utils/mock/core.lua` (+69 -55) ➕ `utils/protocol/actions_validator.lua` (+64 -0) ➕ `utils/protocol/cmodule.lua` (+247 -0) ➕ `utils/protocol/protocol.lua` (+38 -0) ➕ `utils/protocol/smodule.lua` (+237 -0) </details> ### 📄 Description This PR adds several things: - implementation of a common module communication protocol (utils/protocol) which enables module-creators to simplify logic of the module and remove redundant copy-paste code in modules - refactoring of "file_remover" in favor of using utils/protocl as a module baseline - new unit tests for file_remover with covering both server and client parts - some file_remover minor issues fixes - fixes https://github.com/vxcontrol/soldr-modules/issues/17 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-06 22:10:45 -04:00

yindo referenced this issue

2026-06-06 22:10:45 -04:00

[PR #34] [MERGED] XDR-78: fix to upload files with cyrillic sympols in filename (on win… #35

yindo closed this issue

2026-06-06 22:10:45 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vxcontrol/soldr-modules#34