[PR #36] [MERGED] preserve actions list while getting them from callback data #36

New Issue

2026-06-06T22:10:45-04:00

yindo commented

2026-06-06 22:10:45 -04:00

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/soldr-modules/pull/36
Author: @NexoMichael
Created: 12/27/2022
Status: ✅ Merged
Merged: 1/16/2023
Merged by: @asdek

Base: master ← Head: preserve_actions_list

📝 Commits (2)

a50e1d2 preserve actions list while getting them from callback data
0dd62e7 small fixes

📊 Changes

3 files changed (+52 additions, -42 deletions)

View changed files

📝 tests/file_remover_client_spec.lua (+24 -2)
📝 utils/protocol/cmodule.lua (+28 -23)
📝 utils/protocol/smodule.lua (+0 -17)

📄 Description

Description of the Change

The change preserves the "actions" list received in action callback while event is pushed back to a queue, this actions is required to break recursive calls which may happen due to dynamic logic of action-event chains.

Changelog Entry

Added - list of actions is being passed to handler functions so it will be possible to analyze history of calls in business logic code (if needed)
Fixed - missed list of actions in push_event was added

Checklist:

I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/soldr-modules/pull/36 **Author:** [@NexoMichael](https://github.com/NexoMichael) **Created:** 12/27/2022 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `master` ← **Head:** `preserve_actions_list` --- ### 📝 Commits (2) - [`a50e1d2`](https://github.com/vxcontrol/soldr-modules/commit/a50e1d23a16d68d834fd21ce1a6a9ee32fd432dc) preserve actions list while getting them from callback data - [`0dd62e7`](https://github.com/vxcontrol/soldr-modules/commit/0dd62e76d87e649925b214b74c1d97338b4666f7) small fixes ### 📊 Changes **3 files changed** (+52 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `tests/file_remover_client_spec.lua` (+24 -2) 📝 `utils/protocol/cmodule.lua` (+28 -23) 📝 `utils/protocol/smodule.lua` (+0 -17) </details> ### 📄 Description ### Description of the Change The change preserves the "actions" list received in action callback while event is pushed back to a queue, this actions is required to break recursive calls which may happen due to dynamic logic of action-event chains. ### Changelog Entry > Added - list of actions is being passed to handler functions so it will be possible to analyze history of calls in business logic code (if needed) > Fixed - missed list of actions in push_event was added ### Checklist: - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my change. - [x] All new and existing tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-06 22:10:45 -04:00

yindo closed this issue

2026-06-06 22:10:45 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vxcontrol/soldr-modules#36