[PR #40] [MERGED] Suppress debug output by default in the tests #39

New Issue

2026-06-06T22:10:46-04:00

yindo commented

2026-06-06 22:10:46 -04:00

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/soldr-modules/pull/40
Author: @souz9
Created: 1/10/2023
Status: ✅ Merged
Merged: 1/15/2023
Merged by: @asdek

Base: master ← Head: tests-suppress-debug

📝 Commits (2)

2cac2b0 Suppress debug output by default in the tests
d0de07c Simplify log_level usage

📊 Changes

4 files changed (+1 additions, -4 deletions)

View changed files

📝 tests/file_remover_client_spec.lua (+0 -1)
📝 tests/file_remover_server_spec.lua (+0 -1)
📝 tests/proc_terminator_spec.lua (+0 -1)
📝 utils/mock/core.lua (+1 -1)

📄 Description

Description of the Change

Some of the tests use LOG_LEVEL env variable to setup the logging level in tests. However unless LOG_LEVEL is set debug level is used that makes difficult to read the output of the tests by default.

The change removes or "debug" expression, so error log level will be used as default value (as it's declared in mock/core.lua).

How to test the Change

$ busted tests

To enable debug output:

$ LOG_LEVEL=debug busted tests

Checklist:

I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/soldr-modules/pull/40 **Author:** [@souz9](https://github.com/souz9) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 1/15/2023 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `master` ← **Head:** `tests-suppress-debug` --- ### 📝 Commits (2) - [`2cac2b0`](https://github.com/vxcontrol/soldr-modules/commit/2cac2b08de5ef1987f8483f036694cab2278d59d) Suppress debug output by default in the tests - [`d0de07c`](https://github.com/vxcontrol/soldr-modules/commit/d0de07ccf35de16c6d4c4b068b5861a84d9b976a) Simplify log_level usage ### 📊 Changes **4 files changed** (+1 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/file_remover_client_spec.lua` (+0 -1) 📝 `tests/file_remover_server_spec.lua` (+0 -1) 📝 `tests/proc_terminator_spec.lua` (+0 -1) 📝 `utils/mock/core.lua` (+1 -1) </details> ### 📄 Description ### Description of the Change Some of the tests use `LOG_LEVEL` env variable to setup the logging level in tests. However unless LOG_LEVEL is set `debug` level is used that makes difficult to read the output of the tests by default. The change removes `or "debug"` expression, so `error` log level will be used as default value (as it's declared in `mock/core.lua`). ### How to test the Change ```shell $ busted tests ``` To enable debug output: ``` $ LOG_LEVEL=debug busted tests ``` ### Checklist: - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my change. - [x] All new and existing tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-06 22:10:46 -04:00

yindo closed this issue

2026-06-06 22:10:46 -04:00

yindo referenced this issue

2026-06-06 22:10:46 -04:00

[PR #39] [MERGED] add module osquery_linux v1.0.0 #40

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vxcontrol/soldr-modules#39