[PR #44] Allow specifying log files in file_reader using glob patterns #43

New Issue

2026-06-06T22:10:47-04:00

yindo commented

2026-06-06 22:10:47 -04:00

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/soldr-modules/pull/44
Author: @souryogurt
Created: 1/19/2023
Status: 🔄 Open

Base: master ← Head: feature-file_reader-track-files-matching-patterns

📝 Commits (10+)

f10268f Allow specifying log files using glob patterns
f1514ec Return relative paths from find_all_files function
58eb3ef Add directories watcher
55d61b0 Scan for new files every second
ef3ac58 Allow configuring the frequency of updating the file list
e8212d5 Show all found files in the file_reader UI
e7c0b51 Reduce nesting in tests
ae1e67c Reduce nesting in fs_notify module
a0033c5 Create and remove test files for file_reader on test run
922bb10 Fix crash on empty savepoint file in file_reader

📊 Changes

12 files changed (+432 additions, -152 deletions)

View changed files

📝 file_reader/1.0.0/bmodule/main.vue (+18 -2)
📝 file_reader/1.0.0/cmodule/file_reader.lua (+108 -15)
➕ file_reader/1.0.0/cmodule/fs_notify.lua (+62 -0)
📝 file_reader/1.0.0/cmodule/main.lua (+88 -98)
📝 file_reader/1.0.0/config/changelog.json (+12 -0)
📝 file_reader/1.0.0/config/config_schema.json (+9 -1)
📝 file_reader/1.0.0/config/current_config.json (+1 -0)
📝 file_reader/1.0.0/config/default_config.json (+1 -0)
📝 file_reader/1.0.0/config/info.json (+1 -1)
📝 file_reader/1.0.0/config/locale.json (+10 -0)
📝 file_reader/1.0.0/smodule/main.lua (+40 -35)
➕ tests/file_reader_client_fs_notify_spec.lua (+82 -0)

📄 Description

Description of the Change

Users of file_reader module want to track log files of applications with enabled rotation. In this case, they do not know the exact name of the files to be tracked, and they would like to specify them using glob patterns.

Log files can now be specified using glob patterns.

Closes #8

Changelog Entry

Added ability to specify log files in file_reader using glob patterns.

Checklist:

I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/soldr-modules/pull/44 **Author:** [@souryogurt](https://github.com/souryogurt) **Created:** 1/19/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feature-file_reader-track-files-matching-patterns` --- ### 📝 Commits (10+) - [`f10268f`](https://github.com/vxcontrol/soldr-modules/commit/f10268f8b2d6d04fbec5a0c823f7fbb19d143655) Allow specifying log files using glob patterns - [`f1514ec`](https://github.com/vxcontrol/soldr-modules/commit/f1514ecb9ae0e60630d5c308728bfe9cac547648) Return relative paths from find_all_files function - [`58eb3ef`](https://github.com/vxcontrol/soldr-modules/commit/58eb3ef24c91441ef5e0b276becf15d199503cc8) Add directories watcher - [`55d61b0`](https://github.com/vxcontrol/soldr-modules/commit/55d61b0a2a7185dd66dab110aac7d585d32fb4cb) Scan for new files every second - [`ef3ac58`](https://github.com/vxcontrol/soldr-modules/commit/ef3ac58c70d4694996f5200f536d4728d6eed7d3) Allow configuring the frequency of updating the file list - [`e8212d5`](https://github.com/vxcontrol/soldr-modules/commit/e8212d5543cb0bd5b461280427ab28fc755d121c) Show all found files in the file_reader UI - [`e7c0b51`](https://github.com/vxcontrol/soldr-modules/commit/e7c0b515ee2ac3e872f3c476b1e75387010e7343) Reduce nesting in tests - [`ae1e67c`](https://github.com/vxcontrol/soldr-modules/commit/ae1e67c47e84ab5f0eb66936abf1175bc9dc1954) Reduce nesting in fs_notify module - [`a0033c5`](https://github.com/vxcontrol/soldr-modules/commit/a0033c58fd9401977f0879137c3233ff2dbd7f5f) Create and remove test files for file_reader on test run - [`922bb10`](https://github.com/vxcontrol/soldr-modules/commit/922bb10e60be1821285d98375beb1554df428929) Fix crash on empty savepoint file in file_reader ### 📊 Changes **12 files changed** (+432 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `file_reader/1.0.0/bmodule/main.vue` (+18 -2) 📝 `file_reader/1.0.0/cmodule/file_reader.lua` (+108 -15) ➕ `file_reader/1.0.0/cmodule/fs_notify.lua` (+62 -0) 📝 `file_reader/1.0.0/cmodule/main.lua` (+88 -98) 📝 `file_reader/1.0.0/config/changelog.json` (+12 -0) 📝 `file_reader/1.0.0/config/config_schema.json` (+9 -1) 📝 `file_reader/1.0.0/config/current_config.json` (+1 -0) 📝 `file_reader/1.0.0/config/default_config.json` (+1 -0) 📝 `file_reader/1.0.0/config/info.json` (+1 -1) 📝 `file_reader/1.0.0/config/locale.json` (+10 -0) 📝 `file_reader/1.0.0/smodule/main.lua` (+40 -35) ➕ `tests/file_reader_client_fs_notify_spec.lua` (+82 -0) </details> ### 📄 Description ### Description of the Change Users of file_reader module want to track log files of applications with enabled rotation. In this case, they do not know the exact name of the files to be tracked, and they would like to specify them using glob patterns. Log files can now be specified using glob patterns. Closes #8 ### Changelog Entry Added ability to specify log files in file_reader using glob patterns. ### Checklist: - [x] I have updated the documentation accordingly. - [x] I have added tests to cover my change. - [x] All new and existing tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-06 22:10:47 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vxcontrol/soldr-modules#43