From 0211b5cf2d933e10b5916b203fc3fad805a9a3c0 Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Tue, 17 Jun 2014 19:18:28 +0200 Subject: [PATCH] target-ppc: Fix compiler warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gcc reports a warning which is usually wrong: target-ppc/dfp_helper.c: In function ‘dfp_get_digit’: target-ppc/dfp_helper.c:417:1: warning: control reaches end of non-void function [-Wreturn-type] The compiler shows the warning if assert is not marked with the noreturn attribute or if the code is compiled with -DNDEBUG. Using g_assert_not_reached better documents the intention and does not have these problems. Signed-off-by: Stefan Weil Reviewed-by: Alexander Graf Signed-off-by: Michael Tokarev --- target-ppc/dfp_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-ppc/dfp_helper.c b/target-ppc/dfp_helper.c index 773803a285..49820bf21d 100644 --- a/target-ppc/dfp_helper.c +++ b/target-ppc/dfp_helper.c @@ -411,9 +411,8 @@ static inline int dfp_get_digit(decNumber *dn, int n) return (dn->lsu[unit] / 10) % 10; case 2: return dn->lsu[unit] / 100; - default: - assert(0); } + g_assert_not_reached(); } #define DFP_HELPER_TAB(op, dnop, postprocs, size) \