From 026a19c3128678d4fe301fc36e8ffacdc9ecccb8 Mon Sep 17 00:00:00 2001 From: "Edgar E. Iglesias" Date: Thu, 12 May 2016 13:22:27 +0100 Subject: [PATCH] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9 Use extract32 instead of open coding the bit masking when decoding is_signed and is_extended. This streamlines the decoding with some of the other ldst variants. No functional change. Reviewed-by: Sergey Fedorov Signed-off-by: Edgar E. Iglesias Message-id: 1461931684-1867-6-git-send-email-edgar.iglesias@gmail.com Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index b13cff756a..5c8dddbf98 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -2128,8 +2128,8 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint32_t insn) return; } is_store = (opc == 0); - is_signed = opc & (1<<1); - is_extended = (size < 3) && (opc & 1); + is_signed = extract32(opc, 1, 1); + is_extended = (size < 3) && extract32(opc, 0, 1); } switch (idx) {