xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2025-02-19 03:30:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

block: access serialising_in_flight with atomic ops

Browse Source 
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20170605123908.18777-5-pbonzini@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
This commit is contained in:
Paolo Bonzini 2017-06-05 14:38:53 +02:00 committed by Fam Zheng
parent d993b85804
commit 20fc71b25c
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
block/io.c
View File

@ -375,7 +375,7 @@ void bdrv_drain_all(void)
static void tracked_request_end(BdrvTrackedRequest *req) static void tracked_request_end(BdrvTrackedRequest *req)
{ {
if (req->serialising) { if (req->serialising) {
req->bs->serialising_in_flight--; atomic_dec(&req->bs->serialising_in_flight);
} }
QLIST_REMOVE(req, list); QLIST_REMOVE(req, list);
@ -414,7 +414,7 @@ static void mark_request_serialising(BdrvTrackedRequest *req, uint64_t align)
- overlap_offset; - overlap_offset;
if (!req->serialising) { if (!req->serialising) {
req->bs->serialising_in_flight++; atomic_inc(&req->bs->serialising_in_flight);
req->serialising = true; req->serialising = true;
} }
@ -519,7 +519,7 @@ static bool coroutine_fn wait_serialising_requests(BdrvTrackedRequest *self)
bool retry; bool retry;
bool waited = false; bool waited = false;
if (!bs->serialising_in_flight) { if (!atomic_read(&bs->serialising_in_flight)) {
return false; return false;
} }

10
include/block/block_int.h
View File

@ -604,10 +604,6 @@ struct BlockDriverState {
/* Callback before write request is processed */ /* Callback before write request is processed */
NotifierWithReturnList before_write_notifiers; NotifierWithReturnList before_write_notifiers;
/* number of in-flight requests; overall and serialising */
unsigned int in_flight;
unsigned int serialising_in_flight;
bool wakeup; bool wakeup;
/* Offset after the highest byte written to */ /* Offset after the highest byte written to */
@ -634,6 +630,12 @@ struct BlockDriverState {
*/ */
int copy_on_read; int copy_on_read;
/* number of in-flight requests; overall and serialising.
* Accessed with atomic ops.
*/
unsigned int in_flight;
unsigned int serialising_in_flight;
/* do we need to tell the quest if we have a volatile write cache? */ /* do we need to tell the quest if we have a volatile write cache? */
int enable_write_cache; int enable_write_cache;