xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-23 19:49:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

softfloat: fix floatx80 pseudo-denormal addition / subtraction

Browse Source 
The softfloat function addFloatx80Sigs, used for addition of values
with the same sign and subtraction of values with opposite sign, fails
to handle the case where the two values both have biased exponent zero
and there is a carry resulting from adding the significands, which can
occur if one or both values are pseudo-denormals (biased exponent
zero, explicit integer bit 1).  Add a check for that case, so making
the results match those seen on x86 hardware for pseudo-denormals.

Signed-off-by: Joseph Myers <joseph@codesourcery.com>
Message-Id: <alpine.DEB.2.21.2005042337570.22972@digraph.polyomino.org.uk>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Joseph Myers 2020-05-04 23:38:44 +00:00 committed by Richard Henderson
parent 7537c2b4a3
commit 4160280776
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fpu/softfloat.c
View File

@ -5866,6 +5866,12 @@ static floatx80 addFloatx80Sigs(floatx80 a, floatx80 b, flag zSign,
zSig1 = 0;
zSig0 = aSig + bSig;
if ( aExp == 0 ) {
if ((aSig | bSig) & UINT64_C(0x8000000000000000) && zSig0 < aSig) {
/* At least one of the values is a pseudo-denormal,
* and there is a carry out of the result. */
zExp = 1;
goto shiftRight1;
}
if (zSig0 == 0) {
return packFloatx80(zSign, 0, 0);
}

24
tests/tcg/i386/test-i386-pseudo-denormal.c Normal file
View File

@ -0,0 +1,24 @@
/* Test pseudo-denormal operations. */
#include <stdint.h>
#include <stdio.h>
union u {
struct { uint64_t sig; uint16_t sign_exp; } s;
long double ld;
};
volatile union u ld_pseudo_m16382 = { .s = { UINT64_C(1) << 63, 0 } };
volatile long double ld_res;
int main(void)
{
int ret = 0;
ld_res = ld_pseudo_m16382.ld + ld_pseudo_m16382.ld;
if (ld_res != 0x1p-16381L) {
printf("FAIL: pseudo-denormal add\n");
ret = 1;
}
return ret;
}