xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-24 20:19:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qemu-img: Truncate before full preallocation

Browse Source 
In a previous commit (qemu-img: Do not truncate before preallocation) we
moved truncate to the PREALLOC_MODE_OFF branch to avoid slowdown in
posix_fallocate().

However this change is not optimal when using PREALLOC_MODE_FULL, since
knowing the final size from the beginning could allow the file system
driver to do less allocations and possibly avoid fragmentation of the
file.

Now we truncate also before doing full preallocation.

Signed-off-by: Nir Soffer <nirsof@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Nir Soffer 2017-02-17 02:51:26 +02:00 committed by Kevin Wolf
parent 6f993f3fca
commit 5a1dad9d5a
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
block/file-posix.c
View File

@ -1604,6 +1604,17 @@ static int raw_create(const char *filename, QemuOpts *opts, Error **errp)
#endif #endif
case PREALLOC_MODE_FULL: case PREALLOC_MODE_FULL:
{ {
/*
* Knowing the final size from the beginning could allow the file
* system driver to do less allocations and possibly avoid
* fragmentation of the file.
*/
if (ftruncate(fd, total_size) != 0) {
result = -errno;
error_setg_errno(errp, -result, "Could not resize file");
goto out_close;
}
int64_t num = 0, left = total_size; int64_t num = 0, left = total_size;
buf = g_malloc0(65536); buf = g_malloc0(65536);
@ -1642,6 +1653,7 @@ static int raw_create(const char *filename, QemuOpts *opts, Error **errp)
break; break;
} }
out_close:
if (qemu_close(fd) != 0 && result == 0) { if (qemu_close(fd) != 0 && result == 0) {
result = -errno; result = -errno;
error_setg_errno(errp, -result, "Could not close the new file"); error_setg_errno(errp, -result, "Could not close the new file");