xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-24 20:19:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

target/m68k: Fix build Werror with gcc 8.0.1

Browse Source 
Fedora 28 ships with the released gcc 8.

The Werror stems from the compiler finding a path through the second
switch via a missing default case in which src1 is uninitialized, and
not being able to prove that the missing default case is unreachable
due to the first switch.

Simplify the second switch to merge default with OS_LONG,
which returns directly.  This removes the unreachable path.

Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-id: 20180508185520.23757-1-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Richard Henderson 2018-05-08 11:55:20 -07:00 committed by Peter Maydell
parent a8a94ef726
commit 5cbc611107
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
target/m68k/translate.c
View File

@ -2297,7 +2297,7 @@ DISAS_INSN(arith_im)
im = tcg_const_i32(read_im32(env, s));
break;
default:
abort();
g_assert_not_reached();
}
if (with_SR) {
@ -2317,7 +2317,8 @@ DISAS_INSN(arith_im)
}
src1 = gen_get_sr(s);
break;
case OS_LONG:
default:
/* OS_LONG; others already g_assert_not_reached. */
disas_undef(env, s, insn);
return;
}