xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-24 12:09:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

target/ppc: Replace debug messages by asserts for unknown IRQ pins

Browse Source 
If an unknown pin of the IRQ controller is raised, something is very
wrong in the QEMU model. It is better to abort.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210920061203.989563-3-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Cédric Le Goater 2021-09-20 08:12:01 +02:00 committed by David Gibson
parent 2eb1ef73b6
commit 7279810b67
1 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
hw/ppc/ppc.c
View File

@ -165,9 +165,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level)
ppc_set_irq(cpu, PPC_INTERRUPT_RESET, level);
break;
default:
/* Unknown pin - do nothing */
LOG_IRQ("%s: unknown IRQ pin %d\n", __func__, pin);
return;
g_assert_not_reached();
}
if (level)
env->irq_input_state |= 1 << pin;
@ -252,9 +250,7 @@ static void ppc970_set_irq(void *opaque, int pin, int level)
/* XXX: TODO */
break;
default:
/* Unknown pin - do nothing */
LOG_IRQ("%s: unknown IRQ pin %d\n", __func__, pin);
return;
g_assert_not_reached();
}
if (level)
env->irq_input_state |= 1 << pin;
@ -287,9 +283,7 @@ static void power7_set_irq(void *opaque, int pin, int level)
ppc_set_irq(cpu, PPC_INTERRUPT_EXT, level);
break;
default:
/* Unknown pin - do nothing */
LOG_IRQ("%s: unknown IRQ pin %d\n", __func__, pin);
return;
g_assert_not_reached();
}
}
@ -323,9 +317,7 @@ static void power9_set_irq(void *opaque, int pin, int level)
ppc_set_irq(cpu, PPC_INTERRUPT_HVIRT, level);
break;
default:
/* Unknown pin - do nothing */
LOG_IRQ("%s: unknown IRQ pin %d\n", __func__, pin);
return;
g_assert_not_reached();
}
}
@ -459,9 +451,7 @@ static void ppc40x_set_irq(void *opaque, int pin, int level)
ppc_set_irq(cpu, PPC_INTERRUPT_DEBUG, level);
break;
default:
/* Unknown pin - do nothing */
LOG_IRQ("%s: unknown IRQ pin %d\n", __func__, pin);
return;
g_assert_not_reached();
}
if (level)
env->irq_input_state |= 1 << pin;
@ -523,9 +513,7 @@ static void ppce500_set_irq(void *opaque, int pin, int level)
ppc_set_irq(cpu, PPC_INTERRUPT_DEBUG, level);
break;
default:
/* Unknown pin - do nothing */
LOG_IRQ("%s: unknown IRQ pin %d\n", __func__, pin);
return;
g_assert_not_reached();
}
if (level)
env->irq_input_state |= 1 << pin;