From 822f98d2a56c8dcc857bb6a4c4da6382787533a0 Mon Sep 17 00:00:00 2001 From: Jan Kiszka Date: Tue, 31 Jan 2012 13:45:30 +0100 Subject: [PATCH] sdl: Grab input on end of non-absolute mouse click By grabbing the input already on button down, we leave the button in that state for the host GUI. Thus it takes another click after releasing the input again to synchronize the mouse button state. Avoid this by grabbing on button up. Signed-off-by: Jan Kiszka Signed-off-by: Anthony Liguori --- ui/sdl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 0d3a889741..73e58395eb 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -802,8 +802,7 @@ static void handle_mousebutton(DisplayState *ds, SDL_Event *ev) bev = &ev->button; if (!gui_grab && !kbd_mouse_is_absolute()) { - if (ev->type == SDL_MOUSEBUTTONDOWN && - (bev->button == SDL_BUTTON_LEFT)) { + if (ev->type == SDL_MOUSEBUTTONUP && bev->button == SDL_BUTTON_LEFT) { /* start grabbing all events */ sdl_grab_start(); }